mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: spi-devel-general@lists.sourceforge.net,
	Grant Likely <grant.likely@secretlab.ca>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] spi: erase pointer to drvdata on removal
Date: Mon, 14 Jan 2013 02:51:45 +0000	[thread overview]
Message-ID: <20130114025145.GC4928@sirena.org.uk> (raw)
In-Reply-To: <1351793136-14126-1-git-send-email-vivien.didelot@savoirfairelinux.com>

On Thu, Nov 01, 2012 at 02:05:36PM -0400, Vivien Didelot wrote:
> As for i2c-core, let the SPI core handle the removal of the device's
> drvdata, after a remove() or a probe() failure.

Any driver that notices this change is buggy, the driver shouldn't
use a drvdata value that it didn't set.  I had thought this stuff had
all been removed from I2C and either dropped or factored out into the
driver core...

  reply	other threads:[~2013-01-14  2:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-01 18:05 Vivien Didelot
2013-01-14  2:51 ` Mark Brown [this message]
2013-01-14 20:11   ` Grant Likely
2013-01-14 21:24     ` Vivien Didelot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130114025145.GC4928@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    --cc=spi-devel-general@lists.sourceforge.net \
    --cc=vivien.didelot@savoirfairelinux.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome