From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756486Ab3ANJxS (ORCPT ); Mon, 14 Jan 2013 04:53:18 -0500 Received: from mail.skyhub.de ([78.46.96.112]:56841 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755501Ab3ANJxR (ORCPT ); Mon, 14 Jan 2013 04:53:17 -0500 Date: Mon, 14 Jan 2013 10:53:14 +0100 From: Borislav Petkov To: Yinghai Lu Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "Eric W. Biederman" , Andrew Morton , Jan Kiszka , Jason Wessel , linux-kernel@vger.kernel.org, Alexander Duyck Subject: Re: [PATCH v7u1 21/31] x86, kexec: only set ident mapping for ram. Message-ID: <20130114095314.GE1228@liondog.tnic> Mail-Followup-To: Borislav Petkov , Yinghai Lu , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , "Eric W. Biederman" , Andrew Morton , Jan Kiszka , Jason Wessel , linux-kernel@vger.kernel.org, Alexander Duyck References: <1357260531-11115-1-git-send-email-yinghai@kernel.org> <1357260531-11115-22-git-send-email-yinghai@kernel.org> <20130113125653.GA17200@liondog.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jan 13, 2013 at 09:46:17PM -0800, Yinghai Lu wrote: > On Sun, Jan 13, 2013 at 4:56 AM, Borislav Petkov wrote: > > On Thu, Jan 03, 2013 at 04:48:41PM -0800, Yinghai Lu wrote: > >> We should not set mapping for all under max_pfn. > > > > "We should not establish mappings for all memory under max_pfn." > > that is not accurate. > > We should not set mapping for all range under max_pfn. > > or > > We should set mappings only for memory ranges under max_pfn. Ok, that last thing is getting close. So do I understand it correctly now: "We should establish mappings only for memory (memory which is not marked reserved or whatever by E820 or some other mechanism) under max_pfn." ? > >> That causes same problem that is fixed by > > > > "Otherwise, it causes the same ..." > > > >> > >> x86, mm: Only direct map addresses that are marked as E820_RAM > > > > You could add this patch's commit id since it is in tip:x86/mm2 and it > > shouldn't change: 66520ebc2df3. > > why ? they are not in linus tree yet, so it could change if that tip > branch is rebased. Oh, you didn't know: tip branches don't get rebased. At least almost never. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. --