mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Matt Wilson <msw@amazon.com>
Cc: stable@vger.kernel.org, Ian Campbell <Ian.Campbell@citrix.com>,
	Annie Li <annie.li@oracle.com>,
	xen-devel@lists.xen.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] xen/grant-table: correctly initialize grant table version 1
Date: Mon, 14 Jan 2013 10:31:57 -0500	[thread overview]
Message-ID: <20130114153157.GF1156@phenom.dumpdata.com> (raw)
In-Reply-To: <20130114092936.GB15043@u109add4315675089e695.ant.amazon.com>

On Mon, Jan 14, 2013 at 10:29:41AM +0100, Matt Wilson wrote:
> On Fri, Jan 11, 2013 at 04:35:50PM -0500, Konrad Rzeszutek Wilk wrote:
> > 
> > With this patch I get:
> > 
> > [    2.555087] GHES: HEST is not enabled!
> > [    2.560522] ioatdma: Intel(R) QuickData Technology Driver 4.00
> > [    2.569651] ------------[ cut here ]------------
> > [    2.570529] kernel BUG at /home/konrad/linux/drivers/xen/grant-table.c:1175!
> 
> You dropped part of a hunk when you applied the patch:
> 
> @@ -1127,17 +1128,17 @@ static void gnttab_request_version(void)
>                 panic("we need grant tables version 2, but only version 1 is a
>         } else {
>                 grant_table_version = 1;
> +               grefs_per_grant_frame = PAGE_SIZE / sizeof(struct grant_entry_
>                 gnttab_interface = &gnttab_v1_ops;
>         }
>         printk(KERN_INFO "Grant tables using version %d layout.\n",
>                 grant_table_version);
>  }
>  
> I can rebase to v3.8-rc3 if that would help.

Yes pls.
> 
> Matt

  reply	other threads:[~2013-01-14 15:32 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Message-ID: <1355997710.26722.12.camel@zakaz.uk.xensource.com>
2013-01-06 11:14 ` Matt Wilson
2013-01-09  2:40   ` [Xen-devel] " ANNIE LI
2013-01-09 12:02     ` Ian Campbell
2013-01-09 15:02       ` annie li
2013-01-10  9:16       ` Matt Wilson
2013-01-10 10:32         ` Ian Campbell
2013-01-10 11:02         ` ANNIE LI
2013-01-11 21:35   ` Konrad Rzeszutek Wilk
2013-01-14  9:29     ` Matt Wilson
2013-01-14 15:31       ` Konrad Rzeszutek Wilk [this message]
     [not found] <Message-ID: <20130114153157.GF1156@phenom.dumpdata.com>
2013-01-15 13:21 ` [PATCH v3] " Matt Wilson
2013-01-15 13:24   ` Matt Wilson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130114153157.GF1156@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=annie.li@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=msw@amazon.com \
    --cc=stable@vger.kernel.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome