From: Guenter Roeck <linux@roeck-us.net>
To: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Cc: lm-sensors@lm-sensors.org, Jean Delvare <khali@linux-fr.org>,
linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com
Subject: Re: [PATCH v2] hwmon: (sht15) check GPIO directions
Date: Tue, 15 Jan 2013 11:36:11 -0800 [thread overview]
Message-ID: <20130115193611.GA22507@roeck-us.net> (raw)
In-Reply-To: <1358274786-30521-1-git-send-email-vivien.didelot@savoirfairelinux.com>
On Tue, Jan 15, 2013 at 01:33:06PM -0500, Vivien Didelot wrote:
> Without this patch, the SHT15 driver may fail silently with a
> non-bidirectional data line and/or an input-only clock line.
>
> This patch checks the return value of gpio_direction_* function calls
> and returns the error code (if any) to the caller. If an error occurs in
> the read work function (work_funct_t), we wake the queue up directly
> without updating the data->state flag, to notice the waiter of the I/O
> error.
>
> The patch also makes minor cleanups: s/error_ret/unlock for some labels
> and uses devm_gpio_request_one() for the clock line.
>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
Applied to -next.
Thanks,
Guenter
prev parent reply other threads:[~2013-01-15 19:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 18:33 Vivien Didelot
2013-01-15 19:36 ` Guenter Roeck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130115193611.GA22507@roeck-us.net \
--to=linux@roeck-us.net \
--cc=kernel@savoirfairelinux.com \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=vivien.didelot@savoirfairelinux.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®