From: Lasse Collin <lasse.collin@tukaani.org>
To: Florian Fainelli <florian@openwrt.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] decompressors: make the default XZ_BCJ_* config match the selected architecture
Date: Tue, 15 Jan 2013 20:11:17 +0200 [thread overview]
Message-ID: <20130115201117.5ce0a690@tukaani.org> (raw)
In-Reply-To: <1358266931-23401-2-git-send-email-florian@openwrt.org>
On 2013-01-15 Florian Fainelli wrote:
> This patch changes the defautl XZ_BCJ_* config symbol to match the
> configured architecture. It is perfectly legitimate to support
> multiple XZ BCJ filters for different architectures (e.g.: to mount
> foreign squashfs/xz compressed filesystems), it is however more
> natural not to select them all by default, but only the one matching
> the configured architecture.
I don't have a strong opinion on what is the best default setting, so
it's fine to me that the default is changed if that's what people
prefer.
> config XZ_DEC_X86
> bool "x86 BCJ filter decoder" if EXPERT
> - default y
> + default y if X86
> select XZ_DEC_BCJ
[...]
I think the "if EXPERT" strings should be dropped when all BCJ filters
aren't enabled by default. One should be able to enable all filters
without enabling EXPERT.
--
Lasse Collin | IRC: Larhzu @ IRCnet & Freenode
next prev parent reply other threads:[~2013-01-15 18:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-15 16:22 [PATCH 1/2] decompressors: group XZ_DEC_* symbols under an if XZ_BCJ / endif Florian Fainelli
2013-01-15 16:22 ` [PATCH 2/2] decompressors: make the default XZ_BCJ_* config match the selected architecture Florian Fainelli
2013-01-15 18:11 ` Lasse Collin [this message]
2013-01-16 9:33 ` Florian Fainelli
2013-01-18 21:06 ` Lasse Collin
2013-01-25 12:30 ` [PATCH 1/3] decompressors: group XZ_DEC_* symbols under an if XZ_BCJ / endif Florian Fainelli
2013-01-25 12:30 ` [PATCH 2/3] decompressors: drop dependency on CONFIG_EXPERT Florian Fainelli
2013-01-25 12:30 ` [PATCH 3/3] decompressors: make the default XZ_DEC_* config match the selected architecture Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130115201117.5ce0a690@tukaani.org \
--to=lasse.collin@tukaani.org \
--cc=florian@openwrt.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome