From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758205Ab3APQvu (ORCPT ); Wed, 16 Jan 2013 11:51:50 -0500 Received: from mail-ee0-f51.google.com ([74.125.83.51]:52340 "EHLO mail-ee0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758042Ab3APQvs (ORCPT ); Wed, 16 Jan 2013 11:51:48 -0500 Date: Wed, 16 Jan 2013 17:51:44 +0100 From: Cong Ding To: Gleb Natapov Cc: Pekka Enberg , Sasha Levin , Asias He , kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v2] kvm tools: close opened file Message-ID: <20130116165141.GA18593@gmail.com> References: <1358298456-18377-1-git-send-email-dinggnu@gmail.com> <20130116113522.GR11529@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130116113522.GR11529@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The file should be closed before return. Signed-off-by: Cong Ding --- tools/kvm/builtin-setup.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/kvm/builtin-setup.c b/tools/kvm/builtin-setup.c index c5b0566..8b45c56 100644 --- a/tools/kvm/builtin-setup.c +++ b/tools/kvm/builtin-setup.c @@ -159,12 +159,12 @@ static int copy_passwd(const char *guestfs_name) return -1; ret = fprintf(file, "root:x:0:0:root:/root:/bin/sh\n"); - if (ret < 0) - return ret; + if (ret > 0) + ret = 0; fclose(file); - return 0; + return ret; } static int make_guestfs_symlink(const char *guestfs_name, const char *path) -- 1.7.10.4