From: Sarah Sharp <sarah.a.sharp@linux.intel.com>
To: Nickolai Zeldovich <nickolai@csail.mit.edu>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: xhci: fix incorrect bit test
Date: Wed, 16 Jan 2013 16:38:37 -0800 [thread overview]
Message-ID: <20130117003837.GA11383@xanatos> (raw)
In-Reply-To: <1357616371-20689-1-git-send-email-nickolai@csail.mit.edu>
Hi Nickolai,
Thanks for catching this. Don't worry about sending a new patch with
the short description for the commit, I'll fix that when I send it off.
Sarah Sharp
On Mon, Jan 07, 2013 at 10:39:31PM -0500, Nickolai Zeldovich wrote:
> Fix incorrect bit test that originally showed up in
> 4ee823b83bc9851743fab756c76b27d6a1e2472b: use '&' instead of '&&'.
>
> Signed-off-by: Nickolai Zeldovich <nickolai@csail.mit.edu>
> ---
> drivers/usb/host/xhci-ring.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c
> index cbb44b7..06921b6 100644
> --- a/drivers/usb/host/xhci-ring.c
> +++ b/drivers/usb/host/xhci-ring.c
> @@ -1698,7 +1698,7 @@ static void handle_port_status(struct xhci_hcd *xhci,
> faked_port_index + 1);
> if (slot_id && xhci->devs[slot_id])
> xhci_ring_device(xhci, slot_id);
> - if (bus_state->port_remote_wakeup && (1 << faked_port_index)) {
> + if (bus_state->port_remote_wakeup & (1 << faked_port_index)) {
> bus_state->port_remote_wakeup &=
> ~(1 << faked_port_index);
> xhci_test_and_clear_bit(xhci, port_array,
> --
> 1.7.10.4
>
prev parent reply other threads:[~2013-01-17 0:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 3:39 Nickolai Zeldovich
2013-01-08 12:35 ` Sergei Shtylyov
2013-01-17 0:38 ` Sarah Sharp [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130117003837.GA11383@xanatos \
--to=sarah.a.sharp@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=nickolai@csail.mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®