From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers: avoid use after free of a pinctrl context pointer
Date: Thu, 17 Jan 2013 17:37:43 -0800 [thread overview]
Message-ID: <20130118013743.GA7605@kroah.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1301161720440.19928@axis700.grange>
On Wed, Jan 16, 2013 at 05:22:34PM +0100, Guennadi Liakhovetski wrote:
> During probing, pinctrl context is allocated and assigned to the struct
> device::pins pointer. If probing fails or if the driver is later unbound
> and re-probed again, the memory is freed, but the pointer is not cleared.
> On a repeated probing attempt a non-NULL pointer indicates an already
> allocated context, which then gets used. To avoid this the pointer must
> be cleared.
>
> Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
> ---
> drivers/base/dd.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
This can't go through my tree, as it breaks the build. Please send it
to whereever the pinctrl code is coming from.
thanks,
greg k-h
prev parent reply other threads:[~2013-01-18 1:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-16 16:22 Guennadi Liakhovetski
2013-01-18 1:37 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118013743.GA7605@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®