From: Andi Kleen <ak@linux.intel.com>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
mingo@elte.hu, acme@redhat.com, jolsa@redhat.com,
namhyung.kim@lge.com
Subject: Re: [PATCH v3 2/2] perf stat: add interval printing
Date: Fri, 18 Jan 2013 10:30:30 -0800 [thread overview]
Message-ID: <20130118183030.GE4051@tassilo.jf.intel.com> (raw)
In-Reply-To: <1358526409-9382-3-git-send-email-eranian@google.com>
> if (forks) {
> close(go_pipe[1]);
> + if (interval) {
> + while (!waitpid(child_pid, &status, WNOHANG)) {
> + ret = nanosleep(&ts, NULL);
> + if (ret == 0 && interval)
> + print_interval();
It would be good to make sure that if someone Ctrl-Cs
you still print the latest interval(even if shorter)
The rest looks good to me.
-Andi
next prev parent reply other threads:[~2013-01-18 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-18 16:26 [PATCH v3 0/2] perf stat: add interval counter printing Stephane Eranian
2013-01-18 16:26 ` [PATCH v3 1/2] perf tools: add evsel prev_raw_count field Stephane Eranian
2013-01-18 16:26 ` [PATCH v3 2/2] perf stat: add interval printing Stephane Eranian
2013-01-18 18:30 ` Andi Kleen [this message]
2013-01-18 23:03 ` Stephane Eranian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130118183030.GE4051@tassilo.jf.intel.com \
--to=ak@linux.intel.com \
--cc=acme@redhat.com \
--cc=eranian@google.com \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=namhyung.kim@lge.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®