From: Greg KH <greg@kroah.com>
To: "Fangxiaozhi (Franko)" <fangxiaozhi@huawei.com>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Xueguiying (Zihan)" <zihan.xue@huawei.com>,
"Linlei (Lei Lin)" <lei.lin@huawei.com>,
"Yili (Neil)" <neil.yi@huawei.com>,
"Wangyuhua (Roger, Credit)" <wangyuhua@huawei.com>,
"Huqiao (C)" <huqiao36@huawei.com>, "balbi@ti.com" <balbi@ti.com>,
"mdharm-usb@one-eyed-alien.net" <mdharm-usb@one-eyed-alien.net>,
"sebastian@breakpoint.cc" <sebastian@breakpoint.cc>
Subject: Re: USB: storage: optimize the matching rules and support new switch command for Huawei USB storage devices
Date: Mon, 21 Jan 2013 09:12:19 -0800 [thread overview]
Message-ID: <20130121171219.GB4997@kroah.com> (raw)
In-Reply-To: <910F9D9E13B84F4C8FA771DC9BDE99F327016D33@szxeml546-mbx.china.huawei.com>
On Mon, Jan 21, 2013 at 03:37:15AM +0000, Fangxiaozhi (Franko) wrote:
> Dear Greg:
>
> > I get the following errors:
> >
> > drivers/usb/storage/unusual_devs.h:1530:1: error: implicit declaration of
> > function ‘UNUSUAL_VENDOR_INTF’ [-Werror=implicit-function-declaration]
> > drivers/usb/storage/unusual_devs.h:1534:3: warning: missing braces around
> > initializer [-Wmissing-braces]
> > drivers/usb/storage/unusual_devs.h:1534:3: warning: (near initialization for
> > ‘us_unusual_dev_list[186]’) [-Wmissing-braces]
> > drivers/usb/storage/unusual_devs.h:1534:3: error: initializer element is not
> > constant
> > drivers/usb/storage/unusual_devs.h:1534:3: error: (near initialization for
> > ‘us_unusual_dev_list[186].vendorName’)
> > drivers/usb/storage/unusual_devs.h:1537:1: warning: braces around scalar
> > initializer [enabled by default]
> >
> > And it goes on and on...
> ----------The macro define, please see another patch:
> [PATCH 1/1]linux-usb:Define a new macro for USB storage match rules
> http://www.spinics.net/lists/linux-usb/msg76629.html
Please resend it, I do not have this patch anymore in my queue.
Remember, I asked you to resend everything that was needed, with the
proper ordering.
Please resend all patches, properly fixed up, that you wish to see
applied.
thanks,
greg k-h
next prev parent reply other threads:[~2013-01-21 17:11 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 2:55 [PATCH 1/1]linux-usb:optimize " fangxiaozhi 00110321
2013-01-18 23:42 ` USB: storage: optimize " Greg KH
2013-01-21 3:41 ` Fangxiaozhi (Franko)
2013-01-21 17:13 ` Greg KH
2013-01-18 23:43 ` Greg KH
2013-01-20 9:28 ` Felipe Balbi
2013-01-21 3:37 ` Fangxiaozhi (Franko)
2013-01-21 17:12 ` Greg KH [this message]
2013-01-22 9:16 ` Fangxiaozhi (Franko)
2013-01-22 15:03 ` Greg KH
2013-01-23 3:24 ` Fangxiaozhi (Franko)
2013-01-23 3:45 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130121171219.GB4997@kroah.com \
--to=greg@kroah.com \
--cc=balbi@ti.com \
--cc=fangxiaozhi@huawei.com \
--cc=huqiao36@huawei.com \
--cc=lei.lin@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mdharm-usb@one-eyed-alien.net \
--cc=neil.yi@huawei.com \
--cc=sebastian@breakpoint.cc \
--cc=wangyuhua@huawei.com \
--cc=zihan.xue@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®