From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753783Ab3AVMU1 (ORCPT ); Tue, 22 Jan 2013 07:20:27 -0500 Received: from mail.active-venture.com ([67.228.131.205]:61934 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752976Ab3AVMUV (ORCPT ); Tue, 22 Jan 2013 07:20:21 -0500 X-Originating-IP: 108.223.40.66 Date: Tue, 22 Jan 2013 04:20:26 -0800 From: Guenter Roeck To: Samuel Ortiz Cc: linux-kernel@vger.kernel.org, Pawel Moll Subject: Re: [PATCH] mfd: vexpress: export global functions to fix build error Message-ID: <20130122122026.GA12038@roeck-us.net> References: <1357463779-28096-1-git-send-email-linux@roeck-us.net> <20130122033042.GV7409@sortiz-mobl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130122033042.GV7409@sortiz-mobl> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jan 22, 2013 at 04:30:42AM +0100, Samuel Ortiz wrote: > Hi Guenter, > > On Sun, Jan 06, 2013 at 01:16:19AM -0800, Guenter Roeck wrote: > > Compiling vexpress client drivers as module results in error messages such as > > > > ERROR: "__vexpress_config_func_get" [drivers/hwmon/vexpress.ko] undefined! > > ERROR: "vexpress_config_func_put" [drivers/hwmon/vexpress.ko] undefined! > > > > This is because the global functions in drivers/mfd/vexpress-config.c are not > > exported. Fix it. > > > > Signed-off-by: Guenter Roeck > > --- > > drivers/mfd/vexpress-config.c | 8 ++++++-- > > 1 file changed, 6 insertions(+), 2 deletions(-) > Applied, thanks for the fix. > Caution: Looks like I misspelled EXPORT_SYMBOL. Guenter