From: Daniel Vetter <daniel@ffwll.ch>
To: "Su, Xuemin" <xuemin.su@intel.com>
Cc: airlied@linux.ie, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org, yanmin_zhang@linux.intel.com,
bo.he@intel.com
Subject: Re: [PATCH V2 RESEND] drm_crtc: check if fb_create return NULL
Date: Wed, 23 Jan 2013 10:53:37 +0100 [thread overview]
Message-ID: <20130123095337.GQ31870@phenom.ffwll.local> (raw)
In-Reply-To: <1358911167.18561.20.camel@suxuemin.sh.intel.com>
On Wed, Jan 23, 2013 at 11:19:27AM +0800, Su, Xuemin wrote:
> From: xueminsu <xuemin.su@intel.com>
> Date: Tue, 22 Jan 2013 22:39:39 +0800
> Subject: [PATCH] drm_crtc: check if fb_create return NULL
>
> Some buggy driver may still return NULL in fb_create,
> which leads to kernel panic.
>
> Signed-off-by: xueminsu <xuemin.su@intel.com>
Imo just BUG_ON(!fb); and call it a day. Makes it pretty clear what's
expected of the drivers.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-01-23 9:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-23 3:19 Su, Xuemin
2013-01-23 9:53 ` Daniel Vetter [this message]
2013-01-24 0:27 ` Su, Xuemin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130123095337.GQ31870@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=bo.he@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xuemin.su@intel.com \
--cc=yanmin_zhang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®