From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755517Ab3AXTrj (ORCPT ); Thu, 24 Jan 2013 14:47:39 -0500 Received: from mx1.redhat.com ([209.132.183.28]:64998 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751951Ab3AXTrc (ORCPT ); Thu, 24 Jan 2013 14:47:32 -0500 Date: Thu, 24 Jan 2013 20:47:18 +0100 From: Jiri Olsa To: Arnaldo Carvalho de Melo Cc: Vinson Lee , Peter Zijlstra , Paul Mackerras , Ingo Molnar , Namhyung Kim , Pekka Enberg , linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] perf tools: Fix build with older versions of bison. Message-ID: <20130124194718.GB18404@krava.redhat.com> References: <1352843407-30618-1-git-send-email-vlee@twitter.com> <20130123215831.GD6687@ghostprotocols.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130123215831.GD6687@ghostprotocols.net> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 23, 2013 at 06:58:31PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Nov 13, 2012 at 01:50:07PM -0800, Vinson Lee escreveu: > > This patch fixes this build error with older versions of bison. > > Sorry for leaving this patch unapplied, fell thru the cracks. > > But can you please explain what the patch does? right.. the patch looks ok, but more info in change log would be nice jirka > > - Arnaldo > > > CC util/sysfs.o > > BISON util/pmu-bison.c > > util/pmu.y:2.14-24: syntax error, unexpected string, expecting = > > make: *** [util/pmu-bison.c] Error 1 > > > > Signed-off-by: Vinson Lee > > Cc: stable@vger.kernel.org # 3.4+ > > --- > > tools/perf/Makefile | 4 ++-- > > tools/perf/util/parse-events.y | 1 - > > tools/perf/util/pmu.y | 1 - > > 3 files changed, 2 insertions(+), 4 deletions(-) > > > > diff --git a/tools/perf/Makefile b/tools/perf/Makefile > > index 00deed4..c2fb5bc 100644 > > --- a/tools/perf/Makefile > > +++ b/tools/perf/Makefile > > @@ -241,13 +241,13 @@ $(OUTPUT)util/parse-events-flex.c: util/parse-events.l $(OUTPUT)util/parse-event > > $(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/parse-events-flex.h $(PARSER_DEBUG_FLEX) -t util/parse-events.l > $(OUTPUT)util/parse-events-flex.c > > > > $(OUTPUT)util/parse-events-bison.c: util/parse-events.y > > - $(QUIET_BISON)$(BISON) -v util/parse-events.y -d $(PARSER_DEBUG_BISON) -o $(OUTPUT)util/parse-events-bison.c > > + $(QUIET_BISON)$(BISON) -v util/parse-events.y -d $(PARSER_DEBUG_BISON) -o $(OUTPUT)util/parse-events-bison.c -p parse_events_ > > > > $(OUTPUT)util/pmu-flex.c: util/pmu.l $(OUTPUT)util/pmu-bison.c > > $(QUIET_FLEX)$(FLEX) --header-file=$(OUTPUT)util/pmu-flex.h -t util/pmu.l > $(OUTPUT)util/pmu-flex.c > > > > $(OUTPUT)util/pmu-bison.c: util/pmu.y > > - $(QUIET_BISON)$(BISON) -v util/pmu.y -d -o $(OUTPUT)util/pmu-bison.c > > + $(QUIET_BISON)$(BISON) -v util/pmu.y -d -o $(OUTPUT)util/pmu-bison.c -p perf_pmu_ > > > > $(OUTPUT)util/parse-events.o: $(OUTPUT)util/parse-events-flex.c $(OUTPUT)util/parse-events-bison.c > > $(OUTPUT)util/pmu.o: $(OUTPUT)util/pmu-flex.c $(OUTPUT)util/pmu-bison.c > > diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y > > index cd88209..85cdaed 100644 > > --- a/tools/perf/util/parse-events.y > > +++ b/tools/perf/util/parse-events.y > > @@ -1,5 +1,4 @@ > > %pure-parser > > -%name-prefix "parse_events_" > > %parse-param {void *_data} > > %parse-param {void *scanner} > > %lex-param {void* scanner} > > diff --git a/tools/perf/util/pmu.y b/tools/perf/util/pmu.y > > index ec89804..bfd7e85 100644 > > --- a/tools/perf/util/pmu.y > > +++ b/tools/perf/util/pmu.y > > @@ -1,5 +1,4 @@ > > > > -%name-prefix "perf_pmu_" > > %parse-param {struct list_head *format} > > %parse-param {char *name} > > > > -- > > 1.5.4.3 > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > > the body of a message to majordomo@vger.kernel.org > > More majordomo info at http://vger.kernel.org/majordomo-info.html > > Please read the FAQ at http://www.tux.org/lkml/