From: Tejun Heo <tj@kernel.org>
To: aris@redhat.com
Cc: linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
Serge Hallyn <serge.hallyn@canonical.com>
Subject: Re: [PATCH v2 2/4] device_cgroup: keep track of local group settings
Date: Thu, 24 Jan 2013 14:05:53 -0800 [thread overview]
Message-ID: <20130124220553.GW2373@mtj.dyndns.org> (raw)
In-Reply-To: <20130124194957.519573358@napanee.usersys.redhat.com>
On Thu, Jan 24, 2013 at 02:49:59PM -0500, aris@redhat.com wrote:
> In preparation for better hierarchy support, it's needed to retain the local
> settings in order to try to reapply them after a propagated change if they're
> still valid.
>
> Cc: Tejun Heo <tj@kernel.org>
> Cc: Serge Hallyn <serge.hallyn@canonical.com>
> Signed-off-by: Aristeu Rozanski <aris@redhat.com>
Looks okay to me but it would be better if you separate out moving
dev_exception_rm() above dev_exception_add() into a separate patch.
It currently mixes functional and non-functional changes which isn't
very nice.
Thanks.
--
tejun
next prev parent reply other threads:[~2013-01-24 22:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 19:49 [PATCH v2 0/4] devcg: introduce proper hierarchy support aris
2013-01-24 19:49 ` [PATCH v2 1/4] device_cgroup: prepare exception list handling functions for two lists aris
2013-01-24 22:01 ` Tejun Heo
2013-01-24 19:49 ` [PATCH v2 2/4] device_cgroup: keep track of local group settings aris
2013-01-24 22:05 ` Tejun Heo [this message]
2013-01-24 19:50 ` [PATCH v2 3/4] device_cgroup: make may_access() stronger aris
2013-01-24 22:13 ` Tejun Heo
2013-01-24 19:50 ` [PATCH v2 4/4] device_cgroup: propagate local changes down the hierarchy aris
2013-01-24 22:29 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130124220553.GW2373@mtj.dyndns.org \
--to=tj@kernel.org \
--cc=aris@redhat.com \
--cc=cgroups@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serge.hallyn@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®