From: Rik van Riel <riel@redhat.com>
To: Michel Lespinasse <walken@google.com>
Cc: Ingo Molnar <mingo@redhat.com>,
"Paul E. McKenney" <paulmck@us.ibm.com>,
David Howells <dhowells@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Eric Dumazet <edumazet@google.com>,
"Eric W. Biederman" <ebiederm@xmission.com>,
Manfred Spraul <manfred@colorfullife.com>,
linux-kernel@vger.kernel.org
Subject: [RFC PATCH 7/6] kernel: document fast queue spinlocks
Date: Fri, 25 Jan 2013 15:30:09 -0500 [thread overview]
Message-ID: <20130125153009.209f24ba@annuminas.surriel.com> (raw)
In-Reply-To: <1358896415-28569-5-git-send-email-walken@google.com>
Document the fast queue spinlocks in a way that I can understand.
Signed-off-by: Rik van Riel <riel@redhat.com>
---
This may still not be clear to others. Please let me know if you
would like me to change/enhance the documentation, so you can
understand it too.
kernel/queue_spinlock.c | 20 ++++++++++++++++++++
1 files changed, 20 insertions(+), 0 deletions(-)
diff --git a/kernel/queue_spinlock.c b/kernel/queue_spinlock.c
index b571508..dc740fe 100644
--- a/kernel/queue_spinlock.c
+++ b/kernel/queue_spinlock.c
@@ -9,6 +9,23 @@
#include <asm/processor.h> /* for cpu_relax() */
#include <asm/queue_spinlock.h>
+/*
+ * Fast queue spinlocks use a pool of tokens, which contain the actual locks,
+ * and are continuously moved around. Every spinlock is associated with one
+ * token, and every CPU is associated with two tokens.
+ *
+ * When taking a lock, one of the CPU's tokens is associated with the lock,
+ * and the lock's token is associated with the CPU.
+ *
+ * The token that gets associated with the spinlock at lock time will indicate
+ * the lock is busy. The token that was previously associated with the spinlock,
+ * and is now associated with the CPU taking the lock, will indicate whether
+ * the previous lock holder has already unlocked the lock.
+ *
+ * To unlock a fast ticket spinlock, the CPU will unlock the token that it
+ * associated with the spinlock.
+ */
+
DEFINE_PER_CPU(struct q_spinlock_token *, q_spinlock_token[2]);
static inline struct q_spinlock_token *
@@ -25,8 +42,11 @@ ____q_spin_lock(struct q_spinlock *lock,
token = __this_cpu_read(*percpu_token);
token->wait = true;
+ /* Associate our (marked busy) token with the spinlock. */
prev = xchg(&lock->token, token);
+ /* The spinlock's old token is ours now. */
__this_cpu_write(*percpu_token, prev);
+ /* Wait for the spinlock's old token to be unlocked. */
while (ACCESS_ONCE(prev->wait))
cpu_relax();
q_spin_lock_mb(); /* guarantee acquire load semantics */
next prev parent reply other threads:[~2013-01-25 20:54 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-22 23:13 [RFC PATCH 0/6] " Michel Lespinasse
2013-01-22 23:13 ` [RFC PATCH 1/6] kernel: implement queue spinlock API Michel Lespinasse
2013-02-07 22:34 ` Paul E. McKenney
2013-02-07 22:56 ` Eric Dumazet
2013-02-07 23:53 ` Paul E. McKenney
2013-02-07 23:58 ` Michel Lespinasse
2013-02-08 0:03 ` Eric Dumazet
2013-02-08 0:40 ` Paul E. McKenney
2013-02-08 3:48 ` Michel Lespinasse
2013-02-08 4:36 ` Paul E. McKenney
2013-02-08 5:03 ` Paul E. McKenney
2013-02-08 5:11 ` Michel Lespinasse
2013-02-08 16:17 ` Paul E. McKenney
2013-02-07 23:14 ` John Stultz
2013-02-08 0:35 ` Michel Lespinasse
2013-01-22 23:13 ` [RFC PATCH 2/6] net: convert qdisc busylock to use " Michel Lespinasse
2013-01-22 23:13 ` [RFC PATCH 3/6] ipc: convert ipc objects " Michel Lespinasse
2013-01-22 23:13 ` [RFC PATCH 4/6] kernel: faster queue spinlock implementation Michel Lespinasse
2013-01-23 21:55 ` Rik van Riel
2013-01-23 23:52 ` Michel Lespinasse
2013-01-24 0:18 ` Eric Dumazet
2013-01-25 20:30 ` Rik van Riel [this message]
2013-01-22 23:13 ` [RFC PATCH 5/6] net: qdisc busylock updates to account for queue spinlock api change Michel Lespinasse
2013-01-22 23:13 ` [RFC PATCH 6/6] ipc: object locking " Michel Lespinasse
2013-01-22 23:17 ` [RFC PATCH 0/6] fast queue spinlocks Michel Lespinasse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125153009.209f24ba@annuminas.surriel.com \
--to=riel@redhat.com \
--cc=dhowells@redhat.com \
--cc=ebiederm@xmission.com \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manfred@colorfullife.com \
--cc=mingo@redhat.com \
--cc=paulmck@us.ibm.com \
--cc=tglx@linutronix.de \
--cc=walken@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®