From: Andreas Mohr <andi@lisas.de>
To: Philippe De Muyter <phdm@macqel.be>
Cc: linux-kernel@vger.kernel.org, axboe@kernel.dk,
akpm@linux-foundation.org, olh@suse.de,
Philippe De Muyter <phdm@macqel.be>
Subject: Re: [PATCH] block/partition/msdos: detect AIX formatted disks even without 55aa
Date: Fri, 25 Jan 2013 16:36:16 +0100 [thread overview]
Message-ID: <20130125153616.GA27741@rhlx01.hs-esslingen.de> (raw)
In-Reply-To: <1359126343-3525-1-git-send-email-phdm@macqel.be>
Hi,
IMHO that patch would better have a small but important one-liner comment
(one cannot rely on people always making use of SCM history functionality,
thereby this would be at risk of getting reversed accidentally eventually).
E.g.
/* Note order! (some AIX disks, e.g. unbootable kind, have no MSDOS 55aa) */
if (aix_magic_present(state, data)) {
.
.
.
Apart from that: nice compat catch!
HTH,
Andreas Mohr
--
GNU/Linux. It's not the software that's free, it's you.
next prev parent reply other threads:[~2013-01-25 15:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 15:05 Philippe De Muyter
2013-01-25 15:36 ` Andreas Mohr [this message]
2013-01-25 15:51 ` [PATCH v2] " Philippe De Muyter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130125153616.GA27741@rhlx01.hs-esslingen.de \
--to=andi@lisas.de \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=olh@suse.de \
--cc=phdm@macqel.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®