From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756963Ab3A0X7R (ORCPT ); Sun, 27 Jan 2013 18:59:17 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:36519 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754409Ab3A0X7O (ORCPT ); Sun, 27 Jan 2013 18:59:14 -0500 Date: Sun, 27 Jan 2013 18:59:10 -0500 (EST) Message-Id: <20130127.185910.1743425400733006443.davem@davemloft.net> To: jeffrey.t.kirsher@intel.com Cc: apw@canonical.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH] checkpatch.pl: Fix warnings on code comments From: David Miller In-Reply-To: <1359286539-18395-1-git-send-email-jeffrey.t.kirsher@intel.com> References: <1359286539-18395-1-git-send-email-jeffrey.t.kirsher@intel.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Jeff Kirsher Date: Sun, 27 Jan 2013 03:35:39 -0800 > Produces warnings on code comments which follow the Linux coding style > guide. While the desired code comment style for networking my differ > from the rest of the kernel, both styles should be permitted. I was actually going to mention to you guys that I've been lackadasical about enforcing the comment style I want with the Intel drivers. That was a mistake, I should have enforced it strictly, as I do for the other drivers and the core networking code, from the beginning. And it's clearly a mistake if you feel the need to take out the very checkpatch working that's meant to enforce this comment style in all of the networking drivers and core. Do not revert this, follow it's advice instead.