mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andreas Mohr <andi@lisas.de>
To: Zhang Rui <rui.zhang@intel.com>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	linux-acpi@vger.kernel.org, intel-gfx@lists.freedesktop.org,
	rjw@sisk.pl, lenb@kernel.org
Subject: Re: [RFC PATCH 1/3] PM: Introduce suspend state PM_SUSPEND_FREEZE
Date: Tue, 29 Jan 2013 03:05:32 +0100	[thread overview]
Message-ID: <20130129020532.GA22941@rhlx01.hs-esslingen.de> (raw)
In-Reply-To: <1359300060-2967-1-git-send-email-rui.zhang@intel.com>

Hi,

first, thanks a lot for advancing PM infrastructure!

>  #define PM_SUSPEND_ON		((__force suspend_state_t) 0)
> -#define PM_SUSPEND_STANDBY	((__force suspend_state_t) 1)
> +#define PM_SUSPEND_FREEZE	((__force suspend_state_t) 1)
> +#define PM_SUSPEND_STANDBY	((__force suspend_state_t) 2)
>  #define PM_SUSPEND_MEM		((__force suspend_state_t) 3)
> +#define PM_SUSPEND_MIN		PM_SUSPEND_FREEZE
>  #define PM_SUSPEND_MAX		((__force suspend_state_t) 4)

I'll just pretend to be hopeful that you managed to hunt down all
relevant code sites (possibly even splattered around drivers?)
which may have made illegally hard-coded assumptions
about the number of PM_SUSPEND state "enum"s ;)
(e.g. comparisons - such as "==", "<=" etc. - come into mind)


Review of your patch was all fine, nothing to object about.

Thanks,

Andreas Mohr

      parent reply	other threads:[~2013-01-29  2:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-27 15:20 Zhang Rui
2013-01-27 15:20 ` [RFC PATCH 2/3] ACPI: enable ACPI SCI during suspend Zhang Rui
2013-01-27 15:21 ` [RFC PATCH 3/3] i915: ignore lid open event when resuming Zhang Rui
2013-01-27 15:45   ` [Intel-gfx] " Daniel Vetter
2013-01-27 22:21     ` Rafael J. Wysocki
2013-01-27 23:21       ` Daniel Vetter
2013-01-28  2:36     ` Zhang Rui
2013-01-28  8:31       ` Daniel Vetter
2013-01-28 10:06         ` Zhang Rui
2013-01-29 10:10           ` Daniel Vetter
2013-02-04  6:26             ` Zhang Rui
2013-01-29  2:05 ` Andreas Mohr [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130129020532.GA22941@rhlx01.hs-esslingen.de \
    --to=andi@lisas.de \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=rjw@sisk.pl \
    --cc=rui.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®