From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755056Ab3A2IvO (ORCPT ); Tue, 29 Jan 2013 03:51:14 -0500 Received: from cantor2.suse.de ([195.135.220.15]:43704 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754937Ab3A2IvK (ORCPT ); Tue, 29 Jan 2013 03:51:10 -0500 Date: Tue, 29 Jan 2013 09:51:04 +0100 From: Michal Hocko To: Ying Han , Andrew Morton Cc: linux-kernel@vger.kernel.org, KAMEZAWA Hiroyuki , Johannes Weiner , Tejun Heo , Glauber Costa , linux-mm@kvack.org, Li Zefan , Andrew Morton Subject: [PATCH] mmotm: memcgvmscan-do-not-break-out-targeted-reclaim-without-reclaimed-pages.patch fix Message-ID: <20130129085104.GA30322@dhcp22.suse.cz> References: <20130103180901.GA22067@dhcp22.suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130103180901.GA22067@dhcp22.suse.cz> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ying has noticed me (via private email) that the patch is bogus because the break out condition is incorrect. She said she would post a fix but she's been probably too busy. If she doesn't oppose, could you add the follow up fix, please? I am really sorry about this mess. --- >>From 6d23b59e96b8173fae2d0d397cb5e99f16899874 Mon Sep 17 00:00:00 2001 From: Ying Han Date: Tue, 29 Jan 2013 09:42:28 +0100 Subject: [PATCH] mmotm: memcgvmscan-do-not-break-out-targeted-reclaim-without-reclaimed-pages.patch fix We should break out of the hierarchy loop only if nr_reclaimed exceeded nr_to_reclaim and not vice-versa. This patch fixes the condition. Signed-off-by: Ying Han --- mm/vmscan.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/vmscan.c b/mm/vmscan.c index d75c1ec..7528eae 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1985,7 +1985,7 @@ static void shrink_zone(struct zone *zone, struct scan_control *sc) * whole hierarchy is not sufficient. */ if (!global_reclaim(sc) && - sc->nr_to_reclaim >= sc->nr_reclaimed) { + sc->nr_to_reclaim <= sc->nr_reclaimed) { mem_cgroup_iter_break(root, memcg); break; } -- 1.7.10.4 -- Michal Hocko SUSE Labs