From: Daniel Vetter <daniel@ffwll.ch>
To: Takashi Iwai <tiwai@suse.de>
Cc: David Airlie <airlied@linux.ie>,
dri-devel@lists.freedesktop.org,
Bernhard Wiedemann <bwiedemann@suse.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/cirrus: Add bpp option
Date: Tue, 29 Jan 2013 10:53:50 +0100 [thread overview]
Message-ID: <20130129095350.GI14766@phenom.ffwll.local> (raw)
In-Reply-To: <s5htxq0s882.wl%tiwai@suse.de>
On Tue, Jan 29, 2013 at 09:29:17AM +0100, Takashi Iwai wrote:
> Add a new option, bpp, to specify the default bpp value.
>
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
>
> This patch is applied on the top of previous two patches.
> I couldn't find an easy way to specify the default bpp, so I cooked
> the driver quickly. If there is any other convenient way to achieve
> this, let me know...
Well, you can specify the desired bpp with a full mode on the kernel
cmdline - the '-bpp' extension. Reading through the parser I think it
should work even with just the '-bpp' and not a full mode, but I haven't
tested. Look for cmdline_mode->bpp_specified in drm_fb_helper.c and the
relevant parsing code in drm_mode_parse_command_line_for_connector in
drm_modes.c
If that doesn't work for you, I think it's better to extend/fix it than
add driver module options.
Cheers, Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
next prev parent reply other threads:[~2013-01-29 9:51 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-25 16:21 [PATCH 1/2] drm/cirrus: Correct register values for 16bpp Takashi Iwai
2013-01-25 16:21 ` [PATCH 2/2] drm/cirrus: Use 16bpp as default Takashi Iwai
2013-01-29 8:29 ` [PATCH] drm/cirrus: Add bpp option Takashi Iwai
2013-01-29 9:53 ` Daniel Vetter [this message]
2013-01-29 9:57 ` Takashi Iwai
2013-01-29 10:03 ` Daniel Vetter
2013-01-29 8:26 ` [PATCH 1/2] drm/cirrus: Correct register values for 16bpp Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130129095350.GI14766@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=airlied@linux.ie \
--cc=bwiedemann@suse.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®