From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753961Ab3A3IK3 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 30 Jan 2013 03:10:29 -0500
Received: from mail.kernel.org ([198.145.19.201]:44750 "EHLO mail.kernel.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751766Ab3A3IK0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 30 Jan 2013 03:10:26 -0500
Date: Wed, 30 Jan 2013 00:14:18 -0500
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: James Hogan <james.hogan@imgtec.com>
Cc: linux-kernel@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>,
        linux-arch@vger.kernel.org, Alan Cox <alan@lxorguk.ukuu.org.uk>,
        Andrew Morton <akpm@linux-foundation.org>,
        Mauro Carvalho Chehab <mchehab@redhat.com>,
        Cesar Eduardo Barros <cesarb@cesarb.net>,
        Joe Perches <joe@perches.com>, "David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH v3 43/44] tty/metag_da: Add metag DA TTY driver
Message-ID: <20130130051418.GB26687@kroah.com>
References: <1357831872-29451-1-git-send-email-james.hogan@imgtec.com>
 <1357831872-29451-44-git-send-email-james.hogan@imgtec.com>
 <50F3E3FF.4080803@imgtec.com>
 <51026E55.80905@imgtec.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <51026E55.80905@imgtec.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Jan 25, 2013 at 11:36:53AM +0000, James Hogan wrote:
> Hi,
> 
> On 14/01/13 10:54, James Hogan wrote:
> > Here's a new version addressing Jiri's feedback.
> > 
> > Add a TTY driver for communicating over a Meta DA (Debug Adapter)
> > channel using the bios channel SWITCH operation.
> > 
> > Signed-off-by: James Hogan <james.hogan@imgtec.com>
> > Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> > Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> > Cc: Jiri Slaby <jslaby@suse.cz>
> > Cc: Andrew Morton <akpm@linux-foundation.org>
> > Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
> > Cc: Cesar Eduardo Barros <cesarb@cesarb.net>
> > Cc: Joe Perches <joe@perches.com>
> > Cc: "David S. Miller" <davem@davemloft.net>
> 
> If this looks okay, I'd appreciate if somebody could Ack it.
> 
> I have some further patches ready to simplify the code around
> tty_prepare_flip_string and tty_flip_buffer_push to avoid taking a tty
> kref, after Jiri's changes in that area in linux-next. I guess these can
> be applied once both sets of changes are merged.

At first glance, it looks good to me:

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>