mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Richard Cochran <richardcochran@gmail.com>
To: Jeff Mahoney <jeffm@suse.com>
Cc: Linux Kernel Maling List <linux-kernel@vger.kernel.org>,
	Ben Hutchings <bhutchings@solarflare.com>
Subject: Re: [PATCH] ptp: PTP_1588_CLOCK_PCH depends on x86
Date: Wed, 30 Jan 2013 20:02:09 +0100	[thread overview]
Message-ID: <20130130190207.GB6283@netboy.at.omicron.at> (raw)
In-Reply-To: <510958D5.7060206@suse.com>

On Wed, Jan 30, 2013 at 12:31:01PM -0500, Jeff Mahoney wrote:
> The EG20T PCH is only compatible with Intel Atom processors so it
> should depend on x86.

Yes, there is something wrong with PTP_1588_CLOCK_PCH. The last
several times I did 'make oldconfig' for various configs, it asked me
whether to enable this 'new' option. That is really annoying,
especially with non-atom and non-x86 builds.

Ben, you removed the PCH_GBE dependency in 18d359ce. Are you sure that
was the right thing to do?

Thanks,
Richard

 
> Cc: Richard Cochran <richardcochran@gmail.com>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
> ---
>  drivers/ptp/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- a/drivers/ptp/Kconfig
> +++ b/drivers/ptp/Kconfig
> @@ -72,6 +72,7 @@ config DP83640_PHY
>  
>  config PTP_1588_CLOCK_PCH
>  	tristate "Intel PCH EG20T as PTP clock"
> +	depends on X86
>  	select PTP_1588_CLOCK
>  	help
>  	  This driver adds support for using the PCH EG20T as a PTP
> 
> -- 
> Jeff Mahoney
> SUSE Labs

  reply	other threads:[~2013-01-30 19:02 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-30 17:31 Jeff Mahoney
2013-01-30 19:02 ` Richard Cochran [this message]
2013-01-30 19:31   ` Ben Hutchings

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130130190207.GB6283@netboy.at.omicron.at \
    --to=richardcochran@gmail.com \
    --cc=bhutchings@solarflare.com \
    --cc=jeffm@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®