From: Wim Van Sebroeck <wim@iguana.be>
To: Takahisa Tanaka <mc74hc00@gmail.com>
Cc: linux-watchdog@vger.kernel.org,
Paul Menzel <paulepanter@users.sourceforge.net>,
Arkadiusz Miskiewicz <arekm@maven.pl>,
Bjorn Helgaas <bhelgaas@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Jonathan Nieder <jrnieder@gmail.com>,
linux-kernel@vger.kernel.org,
Florian Mickler <florian@mickler.org>
Subject: Re: [PATCH 1/2] sp5100_tco: Fix wrong indirect I/O access for getting value of reserved bits
Date: Wed, 30 Jan 2013 20:19:45 +0100 [thread overview]
Message-ID: <20130130191945.GA20100@spo001.leaseweb.com> (raw)
In-Reply-To: <1358128918-4415-1-git-send-email-mc74hc00@gmail.com>
Hi,
> In case of SB800 or later chipset and re-programming MMIO address(*),
> sp5100_tco module may read incorrect value of reserved bit, because the module
> reads a value from an incorrect I/O address. However, this bug doesn't cause
> a problem, because when re-programming MMIO address, by chance the module
> writes zero (this is BIOS's default value) to the low three bits of register.
> * In most cases, PC with SB8x0 or later chipset doesn't need to re-programming
> MMIO address, because such PC can enable AcpiMmio and can use 0xfed80b00 for
> watchdog register base address.
>
> This patch fixes this bug.
>
> Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=43176
> Signed-off-by: Takahisa Tanaka <mc74hc00@gmail.com>
Added to linux-watchdog-next.
Kind regards,
Wim.
next prev parent reply other threads:[~2013-01-30 19:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-14 2:01 Takahisa Tanaka
2013-01-14 2:01 ` [PATCH 2/2] sp5100_tco: Write back the original value to reserved bits, instead of zero Takahisa Tanaka
2013-01-30 19:20 ` Wim Van Sebroeck
2013-01-31 13:43 ` t t
2013-01-30 19:19 ` Wim Van Sebroeck [this message]
2013-02-06 8:46 ` [PATCH 1/2] sp5100_tco: Fix wrong indirect I/O access for getting value of reserved bits Paul Menzel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130130191945.GA20100@spo001.leaseweb.com \
--to=wim@iguana.be \
--cc=akpm@linux-foundation.org \
--cc=arekm@maven.pl \
--cc=bhelgaas@google.com \
--cc=florian@mickler.org \
--cc=jrnieder@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=mc74hc00@gmail.com \
--cc=paulepanter@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome