From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756544Ab3AaAco (ORCPT ); Wed, 30 Jan 2013 19:32:44 -0500 Received: from [216.32.181.184] ([216.32.181.184]:19661 "EHLO ch1outboundpool.messaging.microsoft.com" rhost-flags-FAIL-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1755313Ab3AaAck (ORCPT ); Wed, 30 Jan 2013 19:32:40 -0500 X-Forefront-Antispam-Report: CIP:70.37.183.190;KIP:(null);UIP:(null);IPV:NLI;H:mail.freescale.net;RD:none;EFVD:NLI X-SpamScore: -3 X-BigFish: VS-3(zz98dI1432I1447Izz1ee6h1de0h1202h1e76h1d1ah1d2ahzz17326ah8275dhz2dh87h2a8h668h839h944hd25hf0ah1220h1288h12a5h12a9h12bdh137ah13b6h1441h1504h1537h153bh162dh1631h1758h18e1h1946h1155h) X-FB-DOMAIN-IP-MATCH: fail Date: Thu, 31 Jan 2013 08:31:20 +0800 From: Shawn Guo To: Thierry Reding CC: Chris Ball , , Subject: Re: [PATCH] mmc: sdhci-esdhc-imx: Remove unused variables Message-ID: <20130131003118.GC2765@S2101-09.ap.freescale.net> References: <1359576681-14797-1-git-send-email-thierry.reding@avionic-design.de> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1359576681-14797-1-git-send-email-thierry.reding@avionic-design.de> User-Agent: Mutt/1.5.21 (2010-09-15) X-OriginatorOrg: sigmatel.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 30, 2013 at 09:11:21PM +0100, Thierry Reding wrote: > Commit 3f175a6 (mmc: sdhci-esdhc-imx: remove ESDHC_CD_GPIO handling from > IO accessory) removed all the code that was using these variables, so it > is safe to drop them. > > Signed-off-by: Thierry Reding Thanks for the fixing, Thierry. But Chris has already queued a fix [1] from Fabio. Shawn [1] http://thread.gmane.org/gmane.linux.kernel.mmc/18724 > --- > drivers/mmc/host/sdhci-esdhc-imx.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-esdhc-imx.c b/drivers/mmc/host/sdhci-esdhc-imx.c > index ae68bc9..509be3a 100644 > --- a/drivers/mmc/host/sdhci-esdhc-imx.c > +++ b/drivers/mmc/host/sdhci-esdhc-imx.c > @@ -144,10 +144,6 @@ static inline void esdhc_clrset_le(struct sdhci_host *host, u32 mask, u32 val, i > > static u32 esdhc_readl_le(struct sdhci_host *host, int reg) > { > - struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > - struct pltfm_imx_data *imx_data = pltfm_host->priv; > - struct esdhc_platform_data *boarddata = &imx_data->boarddata; > - > u32 val = readl(host->ioaddr + reg); > > if (unlikely(reg == SDHCI_CAPABILITIES)) { > @@ -178,7 +174,6 @@ static void esdhc_writel_le(struct sdhci_host *host, u32 val, int reg) > { > struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host); > struct pltfm_imx_data *imx_data = pltfm_host->priv; > - struct esdhc_platform_data *boarddata = &imx_data->boarddata; > u32 data; > > if (unlikely(reg == SDHCI_INT_ENABLE || reg == SDHCI_SIGNAL_ENABLE)) { > -- > 1.8.1.2 >