From: Daniel Vetter <daniel@ffwll.ch>
To: Changlong Xie <changlongx.xie@intel.com>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>,
Ben Widawsky <ben@bwidawsk.net>,
linux-kernel@vger.kernel.org,
Intel Graphics Development <intel-gfx@lists.freedesktop.org>
Subject: Re: [PATCH drm-intel] drm/i915: gen6_gmch_remove can be static
Date: Thu, 31 Jan 2013 09:38:41 +0100 [thread overview]
Message-ID: <20130131083841.GC5885@phenom.ffwll.local> (raw)
In-Reply-To: <20130131033250.GA113229@bee>
On Thu, Jan 31, 2013 at 11:32:50AM +0800, Changlong Xie wrote:
> Signed_off_by: Changlong Xie <changlongx.xie@intel.com>
> Reported-by: Fengguang Wu <fengguang.wu@intel.com>
Queued for -next, thanks for the patch. Note that checkpatch complained
about the _ instead of - in your sob line, fixed up while applying.
-Daniel
> ---
> i915_gem_gtt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/drivers/gpu/drm/i915/i915_gem_gtt.c
> index 87249e8..748015b 100644
> --- a/drivers/gpu/drm/i915/i915_gem_gtt.c
> +++ b/drivers/gpu/drm/i915/i915_gem_gtt.c
> @@ -773,7 +773,7 @@ static int gen6_gmch_probe(struct drm_device *dev,
> return ret;
> }
>
> -void gen6_gmch_remove(struct drm_device *dev)
> +static void gen6_gmch_remove(struct drm_device *dev)
> {
> struct drm_i915_private *dev_priv = dev->dev_private;
> iounmap(dev_priv->gtt.gsm);
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
parent reply other threads:[~2013-01-31 8:36 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <20130131033250.GA113229@bee>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130131083841.GC5885@phenom.ffwll.local \
--to=daniel@ffwll.ch \
--cc=ben@bwidawsk.net \
--cc=changlongx.xie@intel.com \
--cc=daniel.vetter@ffwll.ch \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome