From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753464Ab3AaI4I (ORCPT ); Thu, 31 Jan 2013 03:56:08 -0500 Received: from mail-ee0-f48.google.com ([74.125.83.48]:55209 "EHLO mail-ee0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751248Ab3AaI4G (ORCPT ); Thu, 31 Jan 2013 03:56:06 -0500 Date: Thu, 31 Jan 2013 09:55:55 +0100 From: Fabio Baltieri To: Viresh Kumar Cc: "Rafael J. Wysocki" , cpufreq@vger.kernel.org, linux-pm@vger.kernel.org, Linus Walleij , linaro-dev@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] cpufreq: governors: implement generic policy_is_shared Message-ID: <20130131085555.GB30667@balto.lan> References: <1359620064-14751-1-git-send-email-fabio.baltieri@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux balto 3.8.0-rc3-00668-g55706d3 x86_64 GNU/Linux User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jan 31, 2013 at 02:01:27PM +0530, Viresh Kumar wrote: > On 31 January 2013 13:44, Fabio Baltieri wrote: > > Implement a generic helper function policy_is_shared() to replace the > > current dbs_sw_coordinated_cpus() at cpufreq level, so that it can be > > used by code other than cpufreq governors. > > > > Suggested-by: Viresh Kumar > > Signed-off-by: Fabio Baltieri > > --- > > drivers/cpufreq/cpufreq_conservative.c | 2 +- > > drivers/cpufreq/cpufreq_governor.c | 8 -------- > > drivers/cpufreq/cpufreq_governor.h | 1 - > > drivers/cpufreq/cpufreq_ondemand.c | 2 +- > > include/linux/cpufreq.h | 5 +++++ > > Great, > > But, you missed few places: > > drivers/cpufreq/acpi-cpufreq.c: if (bios_with_sw_any_bug && > cpumask_weight(policy->cpus) == 1) { > drivers/cpufreq/cpufreq_stats.c: if (policy && > (cpumask_weight(policy->cpus) == 1)) { This doesn't look like the same thing to me! Isn't this check here just to trigger during init (exit) on the first (last) cpu? How would you replace it? Fabio > get these fixed too and add my > > Acked-by: Viresh Kumar -- Fabio Baltieri