From: "Serge E. Hallyn" <serge@hallyn.com>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
Serge Hallyn <serge.hallyn@canonical.com>
Subject: Re: [PATCH 3/3] nsproxy: remove duplicate task_cred_xxx for user_ns
Date: Thu, 31 Jan 2013 18:16:55 +0000 [thread overview]
Message-ID: <20130131181655.GA19854@mail.hallyn.com> (raw)
In-Reply-To: <1359624512-23469-3-git-send-email-yuanhan.liu@linux.intel.com>
Quoting Yuanhan Liu (yuanhan.liu@linux.intel.com):
> We can use user_ns, which is also assigned from task_cred_xxx(tsk,
> user_ns), at the beginning of copy_namespaces().
>
> Cc: Serge Hallyn <serge.hallyn@canonical.com>
Acked-by: Serge Hallyn <serge.hallyn@canonical.com>
> Signed-off-by: Yuanhan Liu <yuanhan.liu@linux.intel.com>
> ---
> kernel/nsproxy.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/kernel/nsproxy.c b/kernel/nsproxy.c
> index 78e2ecb..b781e66 100644
> --- a/kernel/nsproxy.c
> +++ b/kernel/nsproxy.c
> @@ -153,8 +153,7 @@ int copy_namespaces(unsigned long flags, struct task_struct *tsk)
> goto out;
> }
>
> - new_ns = create_new_namespaces(flags, tsk,
> - task_cred_xxx(tsk, user_ns), tsk->fs);
> + new_ns = create_new_namespaces(flags, tsk, user_ns, tsk->fs);
> if (IS_ERR(new_ns)) {
> err = PTR_ERR(new_ns);
> goto out;
> --
> 1.7.7.6
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2013-01-31 18:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 9:28 [PATCH 1/3] namespaces: utsname: fix wrong comment about clone_uts_ns() Yuanhan Liu
2013-01-31 9:28 ` [PATCH 2/3] sysctl: put get/get_uts() into CONFIG_PROC_SYSCTL code block Yuanhan Liu
2013-01-31 9:28 ` [PATCH 3/3] nsproxy: remove duplicate task_cred_xxx for user_ns Yuanhan Liu
2013-01-31 18:16 ` Serge E. Hallyn [this message]
2013-01-31 18:17 ` [PATCH 1/3] namespaces: utsname: fix wrong comment about clone_uts_ns() Serge E. Hallyn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130131181655.GA19854@mail.hallyn.com \
--to=serge@hallyn.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=serge.hallyn@canonical.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome