From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756881Ab3BALYn (ORCPT ); Fri, 1 Feb 2013 06:24:43 -0500 Received: from moutng.kundenserver.de ([212.227.126.187]:52174 "EHLO moutng.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756709Ab3BALYl (ORCPT ); Fri, 1 Feb 2013 06:24:41 -0500 Date: Fri, 1 Feb 2013 12:24:37 +0100 From: Thierry Reding To: Sachin Kamat Cc: linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, Laxman Dewangan , linux-serial@vger.kernel.org Subject: Re: [PATCH v2 2/2] serial: tegra: Convert to devm_ioremap_resource() Message-ID: <20130201112437.GB29105@avionic-0098.mockup.avionic-design.de> References: <1359713277-14228-1-git-send-email-sachin.kamat@linaro.org> <1359713277-14228-2-git-send-email-sachin.kamat@linaro.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="QTprm0S8XgL7H0Dt" Content-Disposition: inline In-Reply-To: <1359713277-14228-2-git-send-email-sachin.kamat@linaro.org> User-Agent: Mutt/1.5.21 (2010-09-15) X-Provags-ID: V02:K0:uAhbNh6v2eyqHDFwMAVEwmB0sut2TyTHpGt2tLH+MXB jMqfoLAQfTGQ04t2sbWWwgHHHwUom13/nQ8/Of81WlQA4oY3Eg p1GnW25giut85R8SCj6Vz3O4c5KjyFFuLZJ+5QcuVwRjfXBNM3 hPWMo8qRtKQS0bLFLCWFOSt8l2bCsii9E8sQn3rQZn1CeNykWg asbRgTKkqSJP/xKv92ot18BYJotyKsz2IeNtOHdQmFae+unTCA 1wtYD5s5jxMVMVPNHh4K8h06xX3dXtu9Hi0WI9t452OkQQ9VMk oyrT81QuXFqdCsRxeU9+eUBNLKMlLOKPP2IAT2thresaEoAEwq XpnaMxc4iCN8gFfQtiE1CPxLIkPMwTmU4UsylUkzZa5QtsRRGa XWzCE4mxcM8XVj5fO6u1QEQxLJ+STqldkbevT1HDSsX7yMs+4k EGbUF Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --QTprm0S8XgL7H0Dt Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Feb 01, 2013 at 03:37:57PM +0530, Sachin Kamat wrote: > Use the newly introduced devm_ioremap_resource() instead of > devm_request_and_ioremap() which provides more consistent error handling. >=20 > devm_ioremap_resource() provides its own error messages; so all explicit > error messages can be removed from the failure code paths. >=20 > Signed-off-by: Sachin Kamat > Cc: Laxman Dewangan > Cc: linux-serial@vger.kernel.org > --- > Patch based & compile tested on linux-next tree (20130128). > Changes since v1: > * Dropped the error message as it is now handled by devm_ioremap_resource= () > itself. > --- > drivers/tty/serial/serial-tegra.c | 9 ++++----- > 1 files changed, 4 insertions(+), 5 deletions(-) >=20 > diff --git a/drivers/tty/serial/serial-tegra.c b/drivers/tty/serial/seria= l-tegra.c > index 4f5e629..24ced23 100644 > --- a/drivers/tty/serial/serial-tegra.c > +++ b/drivers/tty/serial/serial-tegra.c > @@ -26,6 +26,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -1302,11 +1303,9 @@ static int tegra_uart_probe(struct platform_device= *pdev) > } > =20 > u->mapbase =3D resource->start; > - u->membase =3D devm_request_and_ioremap(&pdev->dev, resource); > - if (!u->membase) { > - dev_err(&pdev->dev, "memregion/iomap address req failed\n"); > - return -EADDRNOTAVAIL; > - } > + u->membase =3D devm_ioremap_resource(&pdev->dev, resource); > + if (IS_ERR(u->membase)) > + return PTR_ERR(u->membase); > =20 > tup->uart_clk =3D devm_clk_get(&pdev->dev, NULL); > if (IS_ERR(tup->uart_clk)) { Reviewed-by: Thierry Reding --QTprm0S8XgL7H0Dt Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (GNU/Linux) iQIcBAEBAgAGBQJRC6X1AAoJEN0jrNd/PrOhLMEP/AqXdJNkHjhBz3z/T1/rzLN8 psDb4jtRUdT9auiBEi0Nsimuov/Q90OWjcAfKZLHLIMvVNd+t91bzO8OUAk801DB j1EUdsqeKPKMjJa5wiO8lqY/e1t0KWYmNIAui9ig/Mt5grHm6t48wGDE9qBZcb/8 w6pPZ9ZfIlHj68BaDTs9N/z5+GGy/Pwq7ei9xkEmngSCmgBrV3HXnKLYAivr/MGo DyvtUcjN6x5SxaA5k3vvPX+ZsZ3SYtWpScHDexfdTOsGsmLJqijTi2XDQ4NESt1S FyC2YI7NSvze6vJYcszZp5Zc4RmxftHE7UwXWTuFy5pKgAl4tBIXruQdcn02F7Wi 6Y5BQy1M/pHlQce2e0s8fObFm2n1B0yjIJ0rGjgjUOm2JxhV7MPjJwZaps49zkwi wkSWKwToWw06+BAsOueD+IHrJVPgf4VBpsuMY0k9V6UFoQl0kzDN288c9tn3dtBI jGOIIzGCIDsyeyQlRtuHnY9JsKLnStwB8lV0prczaiTzIjc/pGt5nbO1LYz7luNi Mgw1gNTSDSa2hTgdv0sgmcgdhuDCQkZKs2YEo3aZbbUkNN7CHMYnix2Dh8VMTVCM auugtzal+8IAVwD7H8fi/Yhpj7wHMWIgDnYuQv1XwWAVpuiKHHeU0aVT0wHEFkds dZURgGCUvhfD2FJD12mu =iQpb -----END PGP SIGNATURE----- --QTprm0S8XgL7H0Dt--