From: "Henrik Rydberg" <rydberg@euromail.se>
To: Benjamin Tissoires <benjamin.tissoires@gmail.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jiri Kosina <jkosina@suse.cz>, Stephane Chatty <chatty@enac.fr>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/9] Support of Nexio 42" and new default class for hid-multitouch
Date: Sun, 3 Feb 2013 14:07:31 +0100 [thread overview]
Message-ID: <20130203130731.GA2677@polaris.bitmath.org> (raw)
In-Reply-To: <1359649351-11092-1-git-send-email-benjamin.tissoires@gmail.com>
Hi Benjamin,
> so, this is the v2 of the support of win7/8 devices.
Looks like it is getting there, thanks.
> changes since v1:
> - removed the "optimization" patches, as the benefit was minimum
> - introduce a new callback "report" in hid-core that drivers can use to treat the
> report by having it entirely parsed
> - rely on this new hook to support Nexio 42"
As noted in the patches comments, using raw_event() seems sufficient.
> side notes:
> - I've tested removing the heavy call to kzalloc in hid_input_field. The results
> are disapointing -> the processing time remains the same.
> - I've also tested not to rely on .event hook in hid-multitouch but only on .report.
> Idem, I thought it would reduce the code of hid-multitouch and will enhance its
> processing time, but the results are a roughly same number of lines for hid-multitouch
> and the same processing time... :(
> - these 2 tests helped in cleaning the patch set from the last time.
>
> And again, finally, I've pass all the 40 regression tests of my db. \o/
Nice. :-)
Thanks,
Henrik
next prev parent reply other threads:[~2013-02-03 13:01 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-31 16:22 Benjamin Tissoires
2013-01-31 16:22 ` [PATCH v2 1/9] HID: core: add "report" hook, called once the report has been parsed Benjamin Tissoires
2013-02-03 12:27 ` Henrik Rydberg
2013-02-04 9:24 ` Benjamin Tissoires
2013-02-04 11:21 ` Henrik Rydberg
2013-02-04 9:34 ` Jiri Kosina
2013-02-04 9:41 ` Benjamin Tissoires
2013-01-31 16:22 ` [PATCH v2 2/9] HID: multitouch: use the callback "report" instead of sequential events Benjamin Tissoires
2013-01-31 16:22 ` [PATCH v2 3/9] HID: multitouch: add support for Nexio 42" panel Benjamin Tissoires
2013-02-03 13:00 ` Henrik Rydberg
2013-02-04 9:36 ` Benjamin Tissoires
2013-02-04 11:42 ` Henrik Rydberg
2013-02-04 13:42 ` Benjamin Tissoires
2013-01-31 16:22 ` [PATCH v2 4/9] HID: multitouch: fix Win8 protocol for Sharp like devices Benjamin Tissoires
2013-01-31 16:22 ` [PATCH v2 5/9] HID: multitouch: ensure that serial devices make no use of contact count Benjamin Tissoires
2013-01-31 16:22 ` [PATCH v2 6/9] HID: multitouch: fix protocol for Sitronix 1403:5001 Benjamin Tissoires
2013-01-31 16:22 ` [PATCH v2 7/9] HID: multitouch: fix protocol for Cando 2087:0a02 Benjamin Tissoires
2013-01-31 16:22 ` [PATCH v2 8/9] HID: multitouch: fix protocol for Elo panels Benjamin Tissoires
2013-01-31 16:22 ` [PATCH v2 9/9] HID: multitouch: make MT_CLS_ALWAYS_TRUE the new default class Benjamin Tissoires
2013-02-03 13:07 ` Henrik Rydberg [this message]
2013-02-04 9:38 ` [PATCH v2 0/9] Support of Nexio 42" and new default class for hid-multitouch Benjamin Tissoires
2013-02-04 11:54 ` Henrik Rydberg
2013-02-05 11:13 ` Jiri Kosina
2013-02-06 11:04 ` Benjamin Tissoires
2013-02-06 13:11 ` Jiri Kosina
2013-02-06 13:28 ` Benjamin Tissoires
2013-02-06 13:31 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130203130731.GA2677@polaris.bitmath.org \
--to=rydberg@euromail.se \
--cc=benjamin.tissoires@gmail.com \
--cc=chatty@enac.fr \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®