From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756706Ab3BEVSH (ORCPT ); Tue, 5 Feb 2013 16:18:07 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:41766 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754640Ab3BEVSC (ORCPT ); Tue, 5 Feb 2013 16:18:02 -0500 Date: Tue, 5 Feb 2013 13:18:01 -0800 From: Andrew Morton To: li guang Cc: David Rientjes , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mm: break circular include from linux/mmzone.h Message-Id: <20130205131801.131dabb1.akpm@linux-foundation.org> In-Reply-To: <1360043796.4449.24.camel@liguang.fnst.cn.fujitsu.com> References: <1360037707-13935-1-git-send-email-lig.fnst@cn.fujitsu.com> <1360043796.4449.24.camel@liguang.fnst.cn.fujitsu.com> X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 05 Feb 2013 13:56:36 +0800 li guang wrote: > ___ 2013-02-04______ 21:20 -0800___David Rientjes_________ > > On Tue, 5 Feb 2013, liguang wrote: > > > > > linux/mmzone.h included linux/memory_hotplug.h, > > > and linux/memory_hotplug.h also included > > > linux/mmzone.h, so there's a bad cirlular. > > > > > > > And both of these are protected by _LINUX_MMZONE_H and > > __LINUX_MEMORY_HOTPLUG_H, respectively, so what's the problem? > > obviously, It's a logical error, > and It has no more effect other than > combination of these 2 header files. > so, why don't we separate them? > Yup, flattening the hierarchy is nice. And having headers doing mutual inclusion like this is Just Weird.