From: Borislav Petkov <bp@alien8.de>
To: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Cc: dri-devel@lists.freedesktop.org,
lkml <linux-kernel@vger.kernel.org>,
Michal Marek <mmarek@suse.cz>
Subject: Re: [PATCH v2] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled.
Date: Tue, 5 Feb 2013 17:22:06 +0100 [thread overview]
Message-ID: <20130205162206.GJ4827@pd.tnic> (raw)
In-Reply-To: <5111277B.5020607@canonical.com>
On Tue, Feb 05, 2013 at 04:38:35PM +0100, Maarten Lankhorst wrote:
> Argh, next attempt, based on i915's Kconfig.
>
> It seems that not only I have to select ACPI_VIDEO, I also have to select all the dependencies.
> Is this a Kconfig bug or working as intended? i915 seems to have a workaround, so I copied it from
> there. Except it's currently missing select THERMAL, so I guess it didn't get updated when that got
> added.
>
> ---->8
> Having nouveau builtin would still allow ACPI_VIDEO to be used as external module
> if some of the deps for acpi_video have not been met, which would result in a linking
> failure. Solve this by selecting all dependencies as well.
>
> Signed-off-by: Maarten Lankhorst <maarten.lankhorst@canonical.com>
Yep, this takes care of all deps,
Tested-by: Borislav Petkov <bp@suse.de>
Thanks.
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-02-05 16:22 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-04 15:23 drivers/gpu/drm/nouveau/nouveau_acpi.c:420: undefined reference to `acpi_video_get_edid' Borislav Petkov
2013-02-04 15:41 ` [PATCH] drm/nouveau: always select ACPI_VIDEO if ACPI is enabled Maarten Lankhorst
2013-02-05 14:52 ` Borislav Petkov
2013-02-05 15:38 ` [PATCH v2] " Maarten Lankhorst
2013-02-05 16:22 ` Borislav Petkov [this message]
2013-02-20 18:56 ` Borislav Petkov
2013-04-17 10:10 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130205162206.GJ4827@pd.tnic \
--to=bp@alien8.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@canonical.com \
--cc=mmarek@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®