From: Rik van Riel <riel@redhat.com>
To: linux-kernel@vger.kernel.org
Cc: aquini@redhat.com, eric.dumazet@gmail.com, lwoodman@redhat.com,
knoel@redhat.com, chegu_vinod@hp.com,
raghavendra.kt@linux.vnet.ibm.com, mingo@redhat.com
Subject: [PATCH -v5 6/5] x86,smp: add debugging code to track spinlock delay value
Date: Wed, 6 Feb 2013 15:08:33 -0500 [thread overview]
Message-ID: <20130206150833.34d08bd3@cuia.bos.redhat.com> (raw)
In-Reply-To: <20130206150311.19cd1e52@cuia.bos.redhat.com>
Subject: x86,smp: add debugging code to track spinlock delay value
From: Eric Dumazet <eric.dumazet@gmail.com>
This code prints out the maximum spinlock delay value and the
backtrace that pushed it that far.
On systems with serial consoles, the act of printing can cause
the spinlock delay value to explode. It can still be useful as
a debugging tool, but is probably too verbose to merge upstream
in this form.
Not-signed-off-by: Rik van Riel <riel@redhat.com>
Not-signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
---
arch/x86/kernel/smp.c | 8 ++++++++
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/arch/x86/kernel/smp.c b/arch/x86/kernel/smp.c
index fbc5ff3..660f0ec 100644
--- a/arch/x86/kernel/smp.c
+++ b/arch/x86/kernel/smp.c
@@ -146,6 +146,8 @@ static DEFINE_PER_CPU(struct delay_entry [1 << DELAY_HASH_SHIFT], spinlock_delay
},
};
+static DEFINE_PER_CPU(u32, maxdelay);
+
/*
* Wait on a congested ticket spinlock. Many spinlocks are embedded in
* data structures; having many CPUs pounce on the cache line with the
@@ -209,6 +211,12 @@ void ticket_spin_lock_wait(arch_spinlock_t *lock, struct __raw_tickets inc)
}
ent->hash = hash;
ent->delay = delay;
+
+ if (__this_cpu_read(maxdelay) * 4 < delay * 3) {
+ pr_err("cpu %d lock %p delay %d\n", smp_processor_id(), lock, delay>>DELAY_SHIFT);
+ __this_cpu_write(maxdelay, delay);
+ WARN_ON(1);
+ }
}
/*
prev parent reply other threads:[~2013-02-06 20:10 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 20:03 [PATCH -v5 0/5] x86,smp: make ticket spinlock proportional backoff w/ auto tuning Rik van Riel
2013-02-06 20:04 ` [PATCH -v5 1/5] x86,smp: move waiting on contended ticket lock out of line Rik van Riel
2013-02-13 12:06 ` [tip:core/locking] x86/smp: Move " tip-bot for Rik van Riel
2013-02-13 16:20 ` Linus Torvalds
2013-02-13 18:30 ` Linus Torvalds
2013-02-14 0:54 ` H. Peter Anvin
2013-02-14 1:31 ` Linus Torvalds
2013-02-14 1:56 ` H. Peter Anvin
2013-02-14 10:50 ` Ingo Molnar
2013-02-14 16:10 ` Linus Torvalds
2013-02-15 15:57 ` Ingo Molnar
2013-02-15 6:48 ` Benjamin Herrenschmidt
2013-02-13 19:08 ` Rik van Riel
2013-02-13 19:36 ` Linus Torvalds
2013-02-13 22:21 ` Rik van Riel
2013-02-13 22:40 ` Linus Torvalds
2013-02-13 23:41 ` Rik van Riel
2013-02-14 1:21 ` Linus Torvalds
2013-02-14 1:46 ` Linus Torvalds
2013-02-14 10:43 ` Ingo Molnar
2013-02-27 16:42 ` Rik van Riel
2013-02-27 17:10 ` Linus Torvalds
2013-02-27 19:53 ` Rik van Riel
2013-02-27 20:18 ` Linus Torvalds
2013-02-27 21:55 ` Rik van Riel
[not found] ` <CA+55aFwa0EjGG2NUDYVLVBmXJa2k81YiuNO2yggk=GLRQxhhUQ@mail.gmail.com>
2013-02-28 2:58 ` Rik van Riel
2013-02-28 3:19 ` Linus Torvalds
2013-02-28 4:06 ` Davidlohr Bueso
2013-02-28 4:49 ` Linus Torvalds
2013-02-28 15:13 ` Rik van Riel
2013-02-28 18:22 ` Linus Torvalds
2013-02-28 20:26 ` Linus Torvalds
2013-02-28 21:14 ` Rik van Riel
2013-02-28 21:58 ` Linus Torvalds
2013-02-28 22:38 ` Rik van Riel
2013-02-28 23:09 ` Linus Torvalds
2013-03-01 6:42 ` Rik van Riel
2013-03-01 18:18 ` Davidlohr Bueso
2013-03-01 18:50 ` Rik van Riel
2013-03-01 18:52 ` Linus Torvalds
2013-02-06 20:04 ` [PATCH -v5 2/5] x86,smp: proportional backoff for ticket spinlocks Rik van Riel
2013-02-13 12:07 ` [tip:core/locking] x86/smp: Implement " tip-bot for Rik van Riel
2013-02-06 20:05 ` [PATCH -v5 3/5] x86,smp: auto tune spinlock backoff delay factor Rik van Riel
2013-02-13 12:08 ` [tip:core/locking] x86/smp: Auto " tip-bot for Rik van Riel
2013-02-06 20:06 ` [PATCH -v5 4/5] x86,smp: keep spinlock delay values per hashed spinlock address Rik van Riel
2013-02-13 12:09 ` [tip:core/locking] x86/smp: Keep " tip-bot for Eric Dumazet
2013-02-06 20:07 ` [PATCH -v5 5/5] x86,smp: limit spinlock delay on virtual machines Rik van Riel
2013-02-07 11:11 ` Ingo Molnar
2013-02-07 21:24 ` [PATCH fix " Rik van Riel
2013-02-13 12:10 ` [tip:core/locking] x86/smp: Limit " tip-bot for Rik van Riel
2013-02-07 11:25 ` [PATCH -v5 5/5] x86,smp: limit " Stefano Stabellini
2013-02-07 11:59 ` Raghavendra K T
2013-02-07 13:28 ` Rik van Riel
2013-02-06 20:08 ` Rik van Riel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130206150833.34d08bd3@cuia.bos.redhat.com \
--to=riel@redhat.com \
--cc=aquini@redhat.com \
--cc=chegu_vinod@hp.com \
--cc=eric.dumazet@gmail.com \
--cc=knoel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lwoodman@redhat.com \
--cc=mingo@redhat.com \
--cc=raghavendra.kt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®