From: Andrew Morton <akpm@linux-foundation.org>
To: Jonghwa Lee <jonghwa3.lee@samsung.com>
Cc: linux-kernel@vger.kernel.org, a.zummo@towertech.it,
rtc-linux@googlegroups.com
Subject: Re: [PATCH v2] rtc: max8997: Add driver for max8997 rtc.
Date: Thu, 7 Feb 2013 13:44:01 -0800 [thread overview]
Message-ID: <20130207134401.b4d90982.akpm@linux-foundation.org> (raw)
In-Reply-To: <1360234887-12360-1-git-send-email-jonghwa3.lee@samsung.com>
On Thu, 07 Feb 2013 20:01:27 +0900
Jonghwa Lee <jonghwa3.lee@samsung.com> wrote:
> This patch adds rtc driver for Maxim 8997 multifunction chip.
> Max8997 has rtc module in it. and it can be used for timekeeping
> clock and system alarm. It provide various operational mode those are
> BCD/binary, 24/12hour, am/pm. Driver sets binary/24/ for default.
> Maxim 8997 also supports SMPL(Sudden Momentary Power Loss), WTSR
> (Watchdog Timeout and Software Reset).
>
> Signed-off-by: Jonghwa Lee <jonghwa3.lee@samsung.com>
> ---
> v2
> - Add module parameter to enable/disable WTSR, SMPL fuction.
> - Add unregister_rtc_device() for accidental exit in probing.
>
> ...
>
> +/* Module parameter for WTSR function control */
> +static int wtsr_en = 1;
> +module_param(wtsr_en, int, 0444);
> +MODULE_PARM_DESC(wtsr_en, "Wachdog Timeout & Sofware Reset (default=on)");
> +/* Module parameter for SMPL function control */
> +static int smpl_en = 1;
> +module_param(smpl_en, int, 0444);
> +MODULE_PARM_DESC(smpl_en, "Sudden Momentary Power Loss (default=on)");
"default=on" is interesting. For what reasons would a user ever want
to set this "off"? Can we just remove the options and leave these
things enabled all the time for everyone?
next prev parent reply other threads:[~2013-02-07 21:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 11:01 Jonghwa Lee
2013-02-07 21:44 ` Andrew Morton [this message]
2013-02-08 2:19 ` jonghwa3.lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130207134401.b4d90982.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.zummo@towertech.it \
--cc=jonghwa3.lee@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome