From: Tejun Heo <tj@kernel.org>
To: Joonsoo Kim <js1304@gmail.com>, Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH wq/for-3.9] workqueue: move nr_running into worker_pool
Date: Thu, 7 Feb 2013 13:06:00 -0800 [thread overview]
Message-ID: <20130207210600.GU2875@htj.dyndns.org> (raw)
In-Reply-To: <20130124193944.GR2373@mtj.dyndns.org>
On Thu, Jan 24, 2013 at 11:39:44AM -0800, Tejun Heo wrote:
> As nr_running is likely to be accessed from other CPUs during
> try_to_wake_up(), it was kept outside worker_pool; however, while less
> frequent, other fields in worker_pool are accessed from other CPUs
> for, e.g., non-reentrancy check. Also, with recent pool related
> changes, accessing nr_running matching the worker_pool isn't as simple
> as it used to be.
>
> Move nr_running inside worker_pool. Keep it aligned to cacheline and
> define CPU pools using DEFINE_PER_CPU_SHARED_ALIGNED(). This should
> give at least the same cacheline behavior.
>
> get_pool_nr_running() is replaced with direct pool->nr_running
> accesses.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Cc: Joonsoo Kim <js1304@gmail.com>
Applied to wq/for-3.9.
Thanks.
--
tejun
prev parent reply other threads:[~2013-02-07 21:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-24 19:39 Tejun Heo
2013-02-07 21:06 ` Tejun Heo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130207210600.GU2875@htj.dyndns.org \
--to=tj@kernel.org \
--cc=js1304@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®