From: Anton Vorontsov <anton@enomsg.org>
To: Michal Hocko <mhocko@suse.cz>
Cc: linux-kernel@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
Axel Lin <axel.lin@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] da9030_battery: include notifier.h
Date: Fri, 8 Feb 2013 17:45:15 -0800 [thread overview]
Message-ID: <20130209014515.GA9289@lizard.sbx05663.mountca.wayport.net> (raw)
In-Reply-To: <20130206140959.GE10254@dhcp22.suse.cz>
On Wed, Feb 06, 2013 at 03:09:59PM +0100, Michal Hocko wrote:
> Ohh, I have just noticed that this could be introduced by "mm: break
> circular include from linux/mmzone.h" in mm tree.
> Adding Andrew to CC.
The patch is legit, actually. So, I've applied it, thank you!
Anton
> On Wed 06-02-13 10:14:58, Michal Hocko wrote:
> > randconfig complains about:
> > drivers/power/da9030_battery.c:113: error: field ‘nb’ has incomplete type
> >
> > because there is no direct include for notifier.h which defines
> > struct notifier_block.
> >
> > Signed-off-by: Michal Hocko <mhocko@suse.cz>
> > ---
> > drivers/power/da9030_battery.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/power/da9030_battery.c b/drivers/power/da9030_battery.c
> > index 94762e6..e8c5a39 100644
> > --- a/drivers/power/da9030_battery.c
> > +++ b/drivers/power/da9030_battery.c
> > @@ -22,6 +22,7 @@
> >
> > #include <linux/debugfs.h>
> > #include <linux/seq_file.h>
> > +#include <linux/notifier.h>
> >
> > #define DA9030_FAULT_LOG 0x0a
> > #define DA9030_FAULT_LOG_OVER_TEMP (1 << 7)
> > --
> > 1.7.10.4
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at http://www.tux.org/lkml/
>
> --
> Michal Hocko
> SUSE Labs
>
prev parent reply other threads:[~2013-02-09 1:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 9:14 Michal Hocko
2013-02-06 14:09 ` Michal Hocko
2013-02-09 1:45 ` Anton Vorontsov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130209014515.GA9289@lizard.sbx05663.mountca.wayport.net \
--to=anton@enomsg.org \
--cc=akpm@linux-foundation.org \
--cc=axel.lin@gmail.com \
--cc=dwmw2@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®