From: David Miller <davem@davemloft.net>
To: mst@redhat.com
Cc: netdev@vger.kernel.org, eilong@broadcom.com,
jeffrey.t.kirsher@intel.com, jesse.brandeburg@intel.com,
bruce.w.allan@intel.com, carolyn.wyborny@intel.com,
donald.c.skidmore@intel.com, gregory.v.rose@intel.com,
peter.p.waskiewicz.jr@intel.com, alexander.h.duyck@intel.com,
john.ronciak@intel.com, tushar.n.dave@intel.com,
jitendra.kalsaria@qlogic.com, sony.chacko@qlogic.com,
linux-driver@qlogic.com, john.r.fastabend@intel.com,
jacob.e.keller@intel.com, linux-kernel@vger.kernel.org,
e1000-devel@lists.sourceforge.net, bhutchings@solarflare.com,
eric.dumazet@gmail.com
Subject: Re: [PATCHv2-net-3.8 0/3] fix kernel crash with macvtap on top of LRO
Date: Sun, 10 Feb 2013 20:15:12 -0500 (EST) [thread overview]
Message-ID: <20130210.201512.326994514517897067.davem@davemloft.net> (raw)
In-Reply-To: <cover.1360236441.git.mst@redhat.com>
From: "Michael S. Tsirkin" <mst@redhat.com>
Date: Thu, 7 Feb 2013 15:12:56 +0200
> At the moment, macvtap crashes are observed if macvtap is attached
> to an interface with LRO enabled.
> The crash in question is BUG() in macvtap_skb_to_vnet_hdr.
> This happens because several drivers set gso_size but not gso_type
> in incoming skbs.
> This didn't use to be the case: with intel cards on 3.2 and older
> kernels, with qlogic - on 3.4 and older kernels, so it's a regression if
> not a recent one.
> The following patches fix this for qlogic, broadcom and intel drivers.
>
> I tested that the patch fixes the crash for ixgbe but
> don't have qlogic/broadcom hardware to test.
> I also only tested TCPv4.
>
> Please review, and consider for 3.8.
>
> Changes from v1:
> - added missing htons as suggested by Eric
> - backported the relevant bits from
> cbf1de72324a8105ddcc3d9ce9acbc613faea17e for bnx2x
Applied to 'net', thanks.
prev parent reply other threads:[~2013-02-11 1:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-07 13:12 Michael S. Tsirkin
2013-02-07 13:13 ` [PATCHv2-net-3.8 1/3] ixgbe: fix gso type Michael S. Tsirkin
2013-02-07 13:13 ` [PATCHv2-net-3.8 2/3] qlcnic: set gso_type Michael S. Tsirkin
2013-02-07 17:08 ` Jitendra Kalsaria
2013-02-07 13:13 ` [PATCHv2-net-3.8 3/3] bnx2x: " Michael S. Tsirkin
2013-02-07 13:37 ` Dmitry Kravkov
2013-02-07 17:05 ` [PATCHv2-net-3.8 0/3] fix kernel crash with macvtap on top of LRO Ben Hutchings
2013-02-11 1:15 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130210.201512.326994514517897067.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=alexander.h.duyck@intel.com \
--cc=bhutchings@solarflare.com \
--cc=bruce.w.allan@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=donald.c.skidmore@intel.com \
--cc=e1000-devel@lists.sourceforge.net \
--cc=eilong@broadcom.com \
--cc=eric.dumazet@gmail.com \
--cc=gregory.v.rose@intel.com \
--cc=jacob.e.keller@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=jesse.brandeburg@intel.com \
--cc=jitendra.kalsaria@qlogic.com \
--cc=john.r.fastabend@intel.com \
--cc=john.ronciak@intel.com \
--cc=linux-driver@qlogic.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=sony.chacko@qlogic.com \
--cc=tushar.n.dave@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®