From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751951Ab3BLCAn (ORCPT ); Mon, 11 Feb 2013 21:00:43 -0500 Received: from ozlabs.org ([203.10.76.45]:47716 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751004Ab3BLCAm (ORCPT ); Mon, 11 Feb 2013 21:00:42 -0500 Date: Tue, 12 Feb 2013 13:00:39 +1100 From: Michael Ellerman To: Peter Hurley Cc: Jiri Slaby , Greg Kroah-Hartman , Dave Jones , Linux Kernel , Alan Cox Subject: Re: WARNING: at drivers/tty/tty_buffer.c:476 (tty is NULL) Message-ID: <20130212020039.GA8979@concordia> References: <20130102153744.GC25940@redhat.com> <20130118205358.GA6854@redhat.com> <20130118210728.GA16742@kroah.com> <50FB0957.2000400@suse.cz> <1359570837.3325.30.camel@thor.lan> <20130211024412.GA7623@concordia> <1360593750.25941.13.camel@thor.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1360593750.25941.13.camel@thor.lan> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Feb 11, 2013 at 09:42:30AM -0500, Peter Hurley wrote: > Hi Michael, > > On Mon, 2013-02-11 at 13:44 +1100, Michael Ellerman wrote: > > On Wed, Jan 30, 2013 at 01:33:57PM -0500, Peter Hurley wrote: > > > On Sat, 2013-01-19 at 22:00 +0100, Jiri Slaby wrote: > > > > On 01/18/2013 10:07 PM, Greg Kroah-Hartman wrote: > > > > > Jiri, was there anything on the mailing list that I missed that should > > > > > have resolved this issue? I thought it was being worked on, but I can't > > > > > seem to find any resolution at the moment. > > > > > > > > Somebody had a patchset and promised to repost IIRC. I forgot his name > > > > though. > > > > > > > > /me back from digging in the mail history. > > > > > > > > Peter Hurley is the name. > > > > > > > > Peter, what happened with your patches in the end, please? > > > > > > The tty subsystem is very resilient to fixing :) > > > > > > The thing I'm working on right now -- which hopefully is the last issue > > > with the line discipline logic -- occurs with parallel __tty_hangup() > > > and tty_release(). > > > > > > At the moment, I'm trying to narrow the conditions when this happens. > > > > If it helps I seem to be able to reproduce this in just a few seconds by > ^^^^^^^^^^^^^^ > you get this WARNING from a parallel __tty_hangup? > > Or do you mean simply that you get this WARNING? Sorry I just mean I'm seeing the warning, I have no idea how. > > running trinity and hitting Ctrl-C to quit the watchdog. > > Can you reproduce after using the following patch series? > [PATCH v3 00/23] ldisc fixes What are they against? I tried Linus' tree and linux-next but they didn't apply cleanly against either. cheers