From: Felipe Balbi <balbi@ti.com>
To: <kgene@kernel.org>
Cc: "'Vivek Gautam'" <gautam.vivek@samsung.com>,
<linux-usb@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-samsung-soc@vger.kernel.org>,
<devicetree-discuss@lists.ozlabs.org>,
<gregkh@linuxfoundation.org>, <balbi@ti.com>,
<grant.likely@secretlab.ca>, <rob.herring@calxeda.com>,
<sylvester.nawrocki@gmail.com>, <tomasz.figa@gmail.com>,
<av.tikhomirov@samsung.com>, <dianders@chromium.org>,
<p.paneri@samsung.com>
Subject: Re: [PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250
Date: Wed, 13 Feb 2013 10:32:18 +0200 [thread overview]
Message-ID: <20130213083218.GA2426@arwen.pp.htv.fi> (raw)
In-Reply-To: <1e3101ce09b3$b2e178c0$18a46a40$@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 1838 bytes --]
On Tue, Feb 12, 2013 at 10:31:00PM -0800, kgene@kernel.org wrote:
> Vivek Gautam wrote:
> >
> > Based on 'usb-next'
> >
> > Changes from v4:
> > - Modifying function names and driver names to follow a common
> > naming convention.
> > "usb2phy" for samsung-usb2phy driver
> > "usb3phy" for samsung-usb3phy driver
> > - Changing file names "samsung-usb2.c" to "samsung-usb2phy.c" and,
> > "samsung-usb3.c" to "samsung-usb3phy.c"
> > - Removing dependencies for SAMSUNG_USB2PHY and
> > SAMSUNG_USB3PHY.
> > - Arranging SAMSUNG_USB2PHY and SAMSUNG_USB3PHY to select
> > SAMSUNG_USBPHY,
> > which is the usb-phy helper driver.
> >
> > Vivek Gautam (2):
> > usb: phy: samsung: Common out the generic stuff
> > usb: phy: samsung: Add PHY support for USB 3.0 controller
> >
> > drivers/usb/phy/Kconfig | 25 +-
> > drivers/usb/phy/Makefile | 2 +
> > drivers/usb/phy/samsung-usb2phy.c | 511
> > ++++++++++++++++++++++++++
> > drivers/usb/phy/samsung-usb3phy.c | 349 ++++++++++++++++++
> > drivers/usb/phy/samsung-usbphy.c | 717
> +------------------------------------
> > drivers/usb/phy/samsung-usbphy.h | 328 +++++++++++++++++
> > 6 files changed, 1219 insertions(+), 713 deletions(-)
> > create mode 100644 drivers/usb/phy/samsung-usb2phy.c
> > create mode 100644 drivers/usb/phy/samsung-usb3phy.c
> > create mode 100644 drivers/usb/phy/samsung-usbphy.h
> >
> > --
> > 1.7.6.5
>
> For now, looks good to me, and if any enhancement is required, it can be
> done next time.
>
> Felipe, please go ahead with my ack :-)
> Acked-by: Kukjin Kim <kgene.kim@samsung.com>
Thank you, but it's too late for v3.9, this will have to wait until
v3.10. You will get an email once I apply these to my branch.
Cheers
--
balbi
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-02-13 8:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-05 12:44 Vivek Gautam
2013-02-05 12:44 ` [PATCH v5 1/2] usb: phy: samsung: Common out the generic stuff Vivek Gautam
2013-02-05 12:44 ` [PATCH v5 2/2] usb: phy: samsung: Add PHY support for USB 3.0 controller Vivek Gautam
2013-02-13 6:31 ` [PATCH v5 0/2] Adding USB 3.0 DRD-phy support for exynos5250 kgene
2013-02-13 8:32 ` Felipe Balbi [this message]
2013-02-13 9:09 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130213083218.GA2426@arwen.pp.htv.fi \
--to=balbi@ti.com \
--cc=av.tikhomirov@samsung.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=dianders@chromium.org \
--cc=gautam.vivek@samsung.com \
--cc=grant.likely@secretlab.ca \
--cc=gregkh@linuxfoundation.org \
--cc=kgene@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=p.paneri@samsung.com \
--cc=rob.herring@calxeda.com \
--cc=sylvester.nawrocki@gmail.com \
--cc=tomasz.figa@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®