From: Peter De Schrijver <pdeschrijver@nvidia.com>
To: Hiroshi Doyu <hdoyu@nvidia.com>
Cc: "linux-tegra@vger.kernel.org" <linux-tegra@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
"devicetree-discuss@lists.ozlabs.org"
<devicetree-discuss@lists.ozlabs.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH 1/1] ARM: dt: add header to define tegra20 clocks
Date: Thu, 14 Feb 2013 12:12:20 +0200 [thread overview]
Message-ID: <20130214101220.GI3073@tbergstrom-lnx.Nvidia.com> (raw)
In-Reply-To: <1360823899-17846-1-git-send-email-hdoyu@nvidia.com>
On Thu, Feb 14, 2013 at 07:38:17AM +0100, Hiroshi Doyu wrote:
> To replace magic number in "clocks = <&tegra_car 28>;"
>
But then we should probably also remove the enum tegra20_clk and replace it
with this header file. We should also consider removing the list of IDs from
the documentation and refer to the header file instead. Otherwise we will have
3 places which define the same IDs and we need to be sure they stay in sync...
Cheers,
Peter.
next prev parent reply other threads:[~2013-02-14 10:12 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1360791198-29462-1-git-send-email-swarren@wwwdotorg.org>
2013-02-14 6:38 ` Hiroshi Doyu
2013-02-14 10:12 ` Peter De Schrijver [this message]
2013-02-14 13:42 ` Hiroshi Doyu
2013-02-14 14:58 ` Peter De Schrijver
2013-02-14 17:54 ` Stephen Warren
2013-02-19 5:31 ` Shawn Guo
2013-02-19 17:35 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130214101220.GI3073@tbergstrom-lnx.Nvidia.com \
--to=pdeschrijver@nvidia.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=hdoyu@nvidia.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome