From: Youquan Song <youquan.song@linux.intel.com>
To: Libor Pechacek <lpechacek@suse.cz>
Cc: Youquan Song <youquan.song@intel.com>,
htejun@gmail.com, ming.lei@canonical.com, sshtylyov@mvista.com,
linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
seth.heasley@intel.com, jlee@suse.com, james.d.ralston@intel.com,
stable@vger.kernel.org,
Youquan Song <youquan.song@linux.intel.com>
Subject: Re: [PATCH v2] ata: Fix DVD not dectected at some Haswell platforms
Date: Mon, 18 Feb 2013 11:07:23 -0500 [thread overview]
Message-ID: <20130218160723.GA1749@linux-youquan.bj.intel.com> (raw)
In-Reply-To: <20130213083242.GD1106@fm.suse.cz>
>
> As to my understanding Sergei did not suggest citing the whole commit message.
> I also find the numerous references to Sandy Bridge confusing as this is a fix
> for Lynx Point chipset.
>
> How about rephrasing the commit message in a way similar to the following one?
> ------8<-----
> We've hit a problem with DVD not recognized on Haswell Desktop platform which
> includes Lynx Point 2-port SATA controller. This quirk patch disables 32bit
> PIO on the controller in IDE mode.
> ------>8-----
Thanks Libor!
I have updated the comments and sent out a v3 patch out to LKML.
> > + .flags = PIIX_SATA_FLAGS | PIIX_FLAG_SIDPR | PIIX_FLAG_PIO16,
>
> The line might be worth splitting as it's over 80 characters.
>
> Otherwise the patch looks OK to me.
>
Also change it in v3 patch.
Thanks
-Youquan
prev parent reply other threads:[~2013-02-18 3:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-01 15:19 Youquan Song
2013-02-13 8:32 ` Libor Pechacek
2013-02-18 16:07 ` Youquan Song [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130218160723.GA1749@linux-youquan.bj.intel.com \
--to=youquan.song@linux.intel.com \
--cc=htejun@gmail.com \
--cc=james.d.ralston@intel.com \
--cc=jlee@suse.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lpechacek@suse.cz \
--cc=ming.lei@canonical.com \
--cc=seth.heasley@intel.com \
--cc=sshtylyov@mvista.com \
--cc=stable@vger.kernel.org \
--cc=youquan.song@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®