mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Felipe Balbi <balbi@ti.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [BONUS PATCH 2/2] base: core: WARN() about bogus permissions on device attributes
Date: Mon, 18 Feb 2013 11:17:19 -0800	[thread overview]
Message-ID: <20130218191719.GB19724@kroah.com> (raw)
In-Reply-To: <1361214544-14403-2-git-send-email-balbi@ti.com>

On Mon, Feb 18, 2013 at 09:09:04PM +0200, Felipe Balbi wrote:
> Whenever a struct device_attribute is registered
> with mismatched permissions - read permission without
> a show routine or write permission without store
> routine - we will issue a big warning so we catch
> those early enough.
> 
> Signed-off-by: Felipe Balbi <balbi@ti.com>
> ---
> 
> This is completely untested. I have only compile tested
> to make sure I'm not breaking anything.
> 
> Greg, do you think this would be nice to have ? I could
> fire up kvm tomorrow and run on a few of my OMAP-based
> boards to make sure it works as expected.

Looks good, but you better fix up all of the big offenders that this
points out, before I apply it, otherwise we will get a ton of bug
reports :)

thanks,

greg k-h

  reply	other threads:[~2013-02-18 19:17 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-18 19:09 [PATCH 1/2] base: memory: fix soft/hard_offline_page permissions Felipe Balbi
2013-02-18 19:09 ` [BONUS PATCH 2/2] base: core: WARN() about bogus permissions on device attributes Felipe Balbi
2013-02-18 19:17   ` Greg KH [this message]
2013-02-18 19:20     ` Felipe Balbi
2013-02-19  9:59       ` Felipe Balbi
2013-02-20  5:01         ` Greg KH
2013-02-20  8:31           ` [PATCH] " Felipe Balbi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130218191719.GB19724@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=balbi@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®