From: David Howells <dhowells@redhat.com>
To: torvalds@linux-foundation.org
Cc: jkosina@suse.cz, akpm@linux-foundation.org,
keyrings@linux-nfs.org, linux-kernel@vger.kernel.org
Subject: [PATCH] KEYS: Revert one application of "Fix unreachable code" patch
Date: Wed, 20 Feb 2013 12:24:32 +0000 [thread overview]
Message-ID: <20130220122431.1410.12819.stgit@warthog.procyon.org.uk> (raw)
From: Alan Cox <alan@linux.intel.com>
A patch to fix some unreachable code in search_my_process_keyrings() got
applied twice by two different routes upstream:
commit e67eab39bee26f509d38d00ca1a8f24b63f46a31
Author: Alan Cox <alan@linux.intel.com>
Date: Thu Dec 20 15:05:54 2012 -0800
keys: fix unreachable code
and:
commit b010520ab3d2c05eb444ed5e01fe6c33842f597a
Author: Alan Cox <alan@linux.intel.com>
Date: Thu Oct 25 15:23:35 2012 +0100
keys: Fix unreachable code
Unfortunately, the second application removed something it shouldn't have and
this wasn't detected by GIT. This is due to the patch not having sufficient
lines of context to distinguish the two places of application.
So revert the second application of the patch.
Signed-off-by: David Howells <dhowells@redhat.com>
cc: Jiri Kosina <jkosina@suse.cz>
cc: Andrew Morton <akpm@linux-foundation.org>
---
security/keys/process_keys.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/security/keys/process_keys.c b/security/keys/process_keys.c
index 20e4bf5..58dfe08 100644
--- a/security/keys/process_keys.c
+++ b/security/keys/process_keys.c
@@ -367,6 +367,8 @@ key_ref_t search_my_process_keyrings(struct key_type *type,
switch (PTR_ERR(key_ref)) {
case -EAGAIN: /* no key */
+ if (ret)
+ break;
case -ENOKEY: /* negative key */
ret = key_ref;
break;
next reply other threads:[~2013-02-20 12:25 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 12:24 David Howells [this message]
2013-02-20 21:58 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130220122431.1410.12819.stgit@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jkosina@suse.cz \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome