From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Simon Glass <sjg@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Bill Pemberton <wfp5p@virginia.edu>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Javier Martinez Canillas <javier@dowhile0.org>,
Sourav Poddar <sourav.poddar@ti.com>, Felipe Balbi <balbi@ti.com>,
Alban Bedel <alban.bedel@avionic-design.de>,
linux-input@vger.kernel.org
Subject: Re: [PATCH v5 5/6] Input: matrix-keymap: Add function to read the new DT binding
Date: Wed, 20 Feb 2013 10:18:15 -0800 [thread overview]
Message-ID: <20130220181815.GB15152@core.coreip.homeip.net> (raw)
In-Reply-To: <1361381079-26747-6-git-send-email-sjg@chromium.org>
On Wed, Feb 20, 2013 at 09:24:38AM -0800, Simon Glass wrote:
> We now have a binding which adds two parameters to the matrix keypad DT
> node. This is separate from the GPIO-driven matrix keypad binding, and
> unfortunately incompatible, since that uses row-gpios/col-gpios for the
> row and column counts.
>
> So the easiest option here is to provide a function for non-GPIO drivers
> to use to decode the binding.
>
> Note: We could in fact create an entirely separate structure to hold
> these two fields, but it does not seem worth it, yet. If we have more
> parameters then we can add this, and then refactor each driver to hold
> such a structure.
>
> Signed-off-by: Simon Glass <sjg@chromium.org>
> Tested-by: Sourav Poddar <sourav.poddar@ti.com> (v2)
Acked-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
I suppose the EC driver will go through MFD tree, right?
--
Dmitry
next prev parent reply other threads:[~2013-02-20 18:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 17:24 [PATCH v5 0/6] Add ChromeOS Embedded Controller support Simon Glass
2013-02-20 17:24 ` [PATCH v5 1/6] mfd: Add ChromeOS EC messages header Simon Glass
2013-02-20 17:24 ` [PATCH v5 2/6] mfd: Add ChromeOS EC implementation Simon Glass
2013-02-20 18:17 ` Dmitry Torokhov
2013-02-20 17:24 ` [PATCH v5 3/6] mfd: Add ChromeOS EC I2C driver Simon Glass
2013-02-20 18:48 ` Dmitry Torokhov
2013-02-20 17:24 ` [PATCH v5 4/6] mfd: Add ChromeOS EC SPI driver Simon Glass
2013-02-20 17:24 ` [PATCH v5 5/6] Input: matrix-keymap: Add function to read the new DT binding Simon Glass
2013-02-20 18:18 ` Dmitry Torokhov [this message]
2013-02-25 21:53 ` Simon Glass
2013-02-20 17:24 ` [PATCH v5 6/6] Input: Add ChromeOS EC keyboard driver Simon Glass
2013-02-20 18:21 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130220181815.GB15152@core.coreip.homeip.net \
--to=dmitry.torokhov@gmail.com \
--cc=alban.bedel@avionic-design.de \
--cc=balbi@ti.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=javier@dowhile0.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=sjg@chromium.org \
--cc=sourav.poddar@ti.com \
--cc=wfp5p@virginia.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®