From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754324Ab3BUPdL (ORCPT ); Thu, 21 Feb 2013 10:33:11 -0500 Received: from hqemgate03.nvidia.com ([216.228.121.140]:16352 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754264Ab3BUPdI (ORCPT ); Thu, 21 Feb 2013 10:33:08 -0500 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Thu, 21 Feb 2013 07:32:02 -0800 Date: Thu, 21 Feb 2013 17:32:40 +0200 From: Peter De Schrijver To: Stephen Warren CC: Russell King , "linux-doc@vger.kernel.org" , "devicetree-discuss@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , Rob Herring , "linux-tegra@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Hiroshi Doyu Subject: Re: [v2 1/4] ARM: tegra20: create a DT header defining CLK IDs Message-ID: <20130221153240.GN23234@tbergstrom-lnx.Nvidia.com> References: <1360868369-20093-1-git-send-email-hdoyu@nvidia.com> <1360868369-20093-2-git-send-email-hdoyu@nvidia.com> <511D45E0.1080105@wwwdotorg.org> <20130215092407.GO3073@tbergstrom-lnx.Nvidia.com> <511E6639.1090909@wwwdotorg.org> <20130221122536.GJ23234@tbergstrom-lnx.Nvidia.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20130221122536.GJ23234@tbergstrom-lnx.Nvidia.com> X-NVConfidentiality: public User-Agent: Mutt/1.5.20 (2009-06-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 21, 2013 at 01:25:36PM +0100, Peter De Schrijver wrote: > On Fri, Feb 15, 2013 at 05:45:45PM +0100, Stephen Warren wrote: > > ... > > > > I would suggest removing this clock. It's not actually implemented in the CCF > > > and rather useless. If you would gate the CPU clock from the CPU by writing to > > > this register, how would you ungate it? :) Note that this would gate the clock > > > to all CPUs. > > > > (Note that my comment was re: all clocks, not just that one clock) > > > > Can't the PMC or flow-controller ungate the clock based on some event? > > I don't think the flow-controller controls this gate. The usual way of > clockgating a core is to execute a WFI instruction. That will trigger > clockgating the core, unless the flow-controller has been programmed to do > something else. The flow-controller will ungate the clock when there is an > interrupt. > > > Either way, that clock definition exists in HW, right? So I don't think > > there's actually any harm in including the definition in the binding > > even if we never implement/use it. > > The clock definition seems to exist in HW yes, the corresponding resetbit > however is marked as 'reserved' in the Tegra114 documentation. Apparently from Tegra114 onwards, this bit no longer exists. In previous chips, it is just turned by the bootloader running on the AVP and stays on from there on. So at least for Tegra114 I think we remove this clock from the DT binding. Cheers, Peter.