From: Borislav Petkov <bp@alien8.de>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Linux Edac Mailing List <linux-edac@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH EDACv2 01/12] edac: add support for raw error reports
Date: Thu, 21 Feb 2013 17:08:21 +0100 [thread overview]
Message-ID: <20130221160821.GH4694@pd.tnic> (raw)
In-Reply-To: <20130221130125.7f649d4c@redhat.com>
On Thu, Feb 21, 2013 at 01:01:25PM -0300, Mauro Carvalho Chehab wrote:
> I did this way to to follow the "one patch per logical change rule".
> The rationale for this patch is to allow doing raw error reports,
> as needed by changeset 06/12.
Right, but you're adding a new function so why not add the right version
from the get-go? Otherwise the rule above would apply but not for new
code, right?
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-02-21 16:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-21 15:38 [PATCH EDACv2 00/12] Add a driver to report Firmware first errors (via GHES) Mauro Carvalho Chehab
2013-02-21 15:38 ` [PATCH EDACv2 01/12] edac: add support for raw error reports Mauro Carvalho Chehab
2013-02-21 15:53 ` Borislav Petkov
2013-02-21 16:01 ` Mauro Carvalho Chehab
2013-02-21 16:08 ` Borislav Petkov [this message]
2013-02-21 17:47 ` Mauro Carvalho Chehab
2013-02-21 18:03 ` Borislav Petkov
2013-02-21 15:39 ` [PATCH EDACv2 02/12] edac: add support for error type "Info" Mauro Carvalho Chehab
2013-02-21 15:39 ` [PATCH EDACv2 03/12] ghes: move structures/enum to a header file Mauro Carvalho Chehab
2013-02-21 15:39 ` [PATCH EDACv2 04/12] ghes: add the needed hooks for EDAC error report Mauro Carvalho Chehab
2013-02-21 15:39 ` [PATCH EDACv2 05/12] ghes_edac: Register at EDAC core the BIOS report Mauro Carvalho Chehab
2013-02-21 15:39 ` [PATCH EDACv2 06/12] ghes_edac: add support for reporting errors via EDAC Mauro Carvalho Chehab
2013-02-21 15:39 ` [PATCH EDACv2 07/12] ghes_edac: do a better job of filling EDAC DIMM info Mauro Carvalho Chehab
2013-02-21 15:39 ` [PATCH EDACv2 08/12] ghes_edac: Don't credit the same memory dimm twice Mauro Carvalho Chehab
2013-02-21 15:39 ` [PATCH EDACv2 09/12] ghes_edac: Improve driver's printk messages Mauro Carvalho Chehab
2013-02-21 15:39 ` [PATCH EDACv2 10/12] edac: put all arguments for the raw error handling call into a struct Mauro Carvalho Chehab
2013-02-21 15:39 ` [PATCH EDACv2 11/12] ghes_edac: Make it compliant with UEFI spec 2.3.1 Mauro Carvalho Chehab
2013-02-21 15:39 ` [PATCH EDACv2 12/12] ghes_edac: Fix RAS tracing Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130221160821.GH4694@pd.tnic \
--to=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®