From: Michal Marek <mmarek@suse.cz>
To: Jesper Nilsson <jesper.nilsson@axis.com>
Cc: David Howells <dhowells@redhat.com>,
linux-kbuild@vger.kernel.org, linux-kernel@vger.kernel.org,
jespern@axis.com
Subject: Re: [PATCH] kbuild: Fix destination-y for installed headers
Date: Fri, 22 Feb 2013 11:50:26 +0100 [thread overview]
Message-ID: <20130222105026.GG12402@pobox.suse.cz> (raw)
In-Reply-To: <20130202101835.GY23529@axis.com>
On Sat, Feb 02, 2013 at 11:18:35AM +0100, Jesper Nilsson wrote:
> Commit 10b63956fce7f369cc37fd4d994f09bd5203efe4 which plumbed in UAPI
> broke the destination-y functionality of scripts/Makefile.headersinst.
>
> The variable destination-y is used in a := assignment and so is expanded at
> declaration time, and the include of the Kbuild fragments that set
> destination-y to something is after this time, so it now always expands empty.
>
> There are no in-tree users of destination-y, but it allows any
> Kbuild-fragment to redirect where headers are installed.
>
> Just move the assignment of the variable that uses it below the include
> of the Kbuild fragment.
>
> Signed-off-by: Jesper Nilsson <jesper.nilsson@axis.com>
> Cc: Michal Marek <mmarek@suse.cz>
> Cc: David Howells <dhowells@redhat.com>
> ---
> Makefile.headersinst | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git scripts/Makefile.headersinst scripts/Makefile.headersinst
I applied your patch to kbuild.git#kbuild, but please send -p1 patches
next time.
Michal
prev parent reply other threads:[~2013-02-22 10:50 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-02 10:18 Jesper Nilsson
2013-02-22 10:50 ` Michal Marek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130222105026.GG12402@pobox.suse.cz \
--to=mmarek@suse.cz \
--cc=dhowells@redhat.com \
--cc=jesper.nilsson@axis.com \
--cc=jespern@axis.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®