From: Andrew Morton <akpm@linux-foundation.org>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'LKML'" <linux-kernel@vger.kernel.org>,
"'Richard Purdie'" <rpurdie@rpsys.net>
Subject: Re: [PATCH] backlight: ams369fg06: convert ams369fg06 to dev_pm_ops
Date: Fri, 22 Feb 2013 13:26:03 -0800 [thread overview]
Message-ID: <20130222132603.9993aa86.akpm@linux-foundation.org> (raw)
In-Reply-To: <003201ce10e9$61e11b50$25a351f0$%han@samsung.com>
On Fri, 22 Feb 2013 19:42:59 +0900
Jingoo Han <jg1.han@samsung.com> wrote:
> Instead of using legacy suspend/resume methods, using newer dev_pm_ops
> structure allows better control over power management.
>
> ...
>
> @@ -571,12 +571,13 @@ static struct spi_driver ams369fg06_driver = {
> .driver = {
> .name = "ams369fg06",
> .owner = THIS_MODULE,
> +#ifdef CONFIG_PM
> + .pm = &ams369fg06_pm_ops,
> +#endif
> },
> .probe = ams369fg06_probe,
> .remove = ams369fg06_remove,
> .shutdown = ams369fg06_shutdown,
Are the ifdefs needed? There's various macro trickery in pm.h to clean
this up - the rtc drivers use it.
next prev parent reply other threads:[~2013-02-22 21:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-22 10:42 Jingoo Han
2013-02-22 21:26 ` Andrew Morton [this message]
2013-02-25 1:51 ` Jingoo Han
2013-02-25 1:56 ` [PATCH V2] " Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130222132603.9993aa86.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome