From: Ira Weiny <weiny2@llnl.gov>
To: "Husam Kahalah" <HKahalah@asaltech.com>
Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] infiniband-diags/saquery.c: switchinfo support added
Date: Sun, 24 Feb 2013 17:34:47 -0800 [thread overview]
Message-ID: <20130224173447.08f0201f24e97ea4c62a5a60@llnl.gov> (raw)
In-Reply-To: <WC20130224082247.780048@asaltech.com>
On Sun, 24 Feb 2013 10:22:47 +0200
"Husam Kahalah" <HKahalah@asaltech.com> wrote:
> Thank you for your time, I have the following notes:
> I plan to add support for more records other than switchInfoRecord like
> smInfo, multipath, nodeInfo
That would be great!
> I plan also to add component filter to those records attributes in the same
> way that pathInfo and MCR were implemented, this is the reason why I started
> adding attributes to query_params structure
> I'am not talking about RID(record identifier) attributes only, but also
> about other attributes that may differ between records.
> If it is available to add to query_params structure in that way let me know
> , otherwise I will add just RID attributes in the suggested way.
>
I am not against adding fields to query_params. However, we have a standard way to specify the RID components like LID which should be followed.
If you need new components to be specified for new attributes it is fine to add them to query_params. That said, any components which already have options should be overloaded; for example MultiPathRecord.SL should use the --sl option.
Does this make sense?
Thanks,
Ira
>
> -----Original Message-----
> From: Ira Weiny <weiny2@llnl.gov>
> To: Ira Weiny <weiny2@llnl.gov>
> Cc: "Husam Kahalah" <HKahalah@asaltech.com>, linux-rdma@vger.kernel.org,
> linux-kernel@vger.kernel.org
> Date: Thu, 21 Feb 2013 10:33:44 -0800
> Subject: Re: [PATCH] infiniband-diags/saquery.c: switchinfo support added
>
> On Thu, 21 Feb 2013 10:09:00 -0800
> Ira Weiny <weiny2@llnl.gov> wrote:
>
> [snip]
>
> > > + ib_net16_t swir_lid;
> >
> > We don't need this field or lid option. Other records simply have an
> optional parameter to specify the lid.
> >
> > The usage should be:
> >
> > SwitchRecord [lid]
> >
>
> Sorry I meant "SwitchInfoRecord" or SWIR.
>
> Ira
>
> [snip]
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Ira Weiny
Member of Technical Staff
Lawrence Livermore National Lab
925-423-8008
weiny2@llnl.gov
next prev parent reply other threads:[~2013-02-25 1:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <WC20130221094946.530170@asaltech.com>
2013-02-21 18:09 ` Ira Weiny
2013-02-21 18:33 ` Ira Weiny
[not found] ` <WC20130224082247.780048@asaltech.com>
2013-02-25 1:34 ` Ira Weiny [this message]
[not found] <WC20130228061138.140078@asaltech.com>
2013-03-01 1:37 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130224173447.08f0201f24e97ea4c62a5a60@llnl.gov \
--to=weiny2@llnl.gov \
--cc=HKahalah@asaltech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®