Re: [PATCH 3/3] convert headers_install.pl->headers_install.sh

[Michal Marek <mmarek@suse.cz>]

On Mon, Dec 17, 2012 at 05:12:51PM -0800, rob@landley.net wrote:
> From: Rob Landley <rob@landley.net>
> 
> Remove perl from make headers_install by replacing a perl script (doing
> a simple regex search and replace) with a smaller, faster, simpler,
> POSIX-2008 shell script implementation.  The new shell script is a single
> for loop calling sed and piping its output through unifdef to produce the
> target file.
> 
> Signed-off-by: Rob Landley <rob@landley.net>
> ---
> 
>  scripts/Makefile.headersinst |    4 +-
>  scripts/headers_install.pl   |   63 ---------------------------------
>  scripts/headers_install.sh   |   43 ++++++++++++++++++++++
>  3 files changed, 45 insertions(+), 65 deletions(-)

Hi Rob,

sorry for the long delay. In general, the patch looks OK, I only have
two remarks:


> +		-e 's/(^|[ \t])(inline|asm|volatile)([ \t(]|$)/\1__\2__\3/g' \

This regexp does not match the 'volatile' in

#define XVMCLOCKPTR(saPriv,lockNo)					\
	((volatile struct drm_hw_lock *)(((((unsigned long) (saPriv)->XvMCLockArea) + \
				      (VIA_MAX_CACHELINE_SIZE - 1)) &	\
				     ~(VIA_MAX_CACHELINE_SIZE - 1)) +	\
				    VIA_MAX_CACHELINE_SIZE*(lockNo)))

in include/uapi/drm/via_drm.h.


> --- a/scripts/headers_install.pl
> +++ /dev/null
> @@ -1,63 +0,0 @@
> -#!/usr/bin/perl -w
> -#
> -# headers_install prepare the listed header files for use in
> -# user space and copy the files to their destination.
> -#
> -# Usage: headers_install.pl readdir installdir arch [files...]
> -# installdir: dir to install the files to
> -# arch:       current architecture
> -#             arch is used to force a reinstallation when the arch
> -#             changes because kbuild then detect a command line change.

You are not passing $(SRCARCH) to the shell script. This seems OK, as
the list of files changes if needed, but the change should be mentioned
in the changelog.

Thanks,
Michal