From: Andrew Morton <akpm@linux-foundation.org>
To: "'Tejun Heo'" <tj@kernel.org>
Cc: Jingoo Han <jg1.han@samsung.com>,
linux-kernel@vger.kernel.org,
"'Alessandro Zummo'" <a.zummo@towertech.it>,
rtc-linux@googlegroups.com
Subject: Re: [PATCH] rtc: add devm_rtc_device_{register,unregister}()
Date: Mon, 25 Feb 2013 15:38:11 -0800 [thread overview]
Message-ID: <20130225153811.2408f9c0.akpm@linux-foundation.org> (raw)
In-Reply-To: <20130225233345.GB2679@htj.dyndns.org>
On Mon, 25 Feb 2013 15:33:45 -0800
"'Tejun Heo'" <tj@kernel.org> wrote:
> On Mon, Feb 25, 2013 at 02:29:57PM -0800, Andrew Morton wrote:
> > > + * Managed rtc_device_register(). The rtc_device returned from this function
> > > + * are automatically freed on driver detach. See rtc_device_register()
> > > + * for more information.
> > > + */
> >
> > I think the name is inappropriate. devm functions start with "devm"
> > and rtc functions start with "rtc" and this code is a part of rtc core,
> > not a part of devm core. Hence it should be something like
> > "rtc_devm_device_register".
>
> I think devm_rtc_ is better. All other devm interface functions put
> devm_ prefix first
makes no sense. Whatever.
next prev parent reply other threads:[~2013-02-25 23:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-25 7:35 Jingoo Han
2013-02-25 22:29 ` Andrew Morton
2013-02-25 23:33 ` 'Tejun Heo'
2013-02-25 23:38 ` Andrew Morton [this message]
2013-02-25 23:32 ` 'Tejun Heo'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130225153811.2408f9c0.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=a.zummo@towertech.it \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rtc-linux@googlegroups.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®